Merge lp:~alucryd/switchboard-plug-networking/no-ifconfig into lp:~elementary-pantheon/switchboard-plug-networking/trunk
Proposed by
Maxime Gauduin
Status: | Superseded |
---|---|
Proposed branch: | lp:~alucryd/switchboard-plug-networking/no-ifconfig |
Merge into: | lp:~elementary-pantheon/switchboard-plug-networking/trunk |
Diff against target: |
117 lines (+25/-41) 1 file modified
src/Widgets/Device/DevicePage.vala (+25/-41) |
To merge this branch: | bzr merge lp:~alucryd/switchboard-plug-networking/no-ifconfig |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Bieńkowski (community) | Needs Fixing | ||
Viko Adi Rahmawan (community) | Needs Fixing | ||
Review via email: mp+262346@code.launchpad.net |
This proposal has been superseded by a proposal from 2015-07-04.
Description of the change
ifconfig has been deprecated for some time by most distros. This change makes the plug read the received and transferred bytes values from /sys and process them to make them look pretty.
I also fixed all whitespace issues while I was at it.
I'm open to criticism as I've never written any vala or C code before so I may have done some stupid things.
To post a comment you must log in.
You can use format_size (http:// valadoc. org/#!api= glib-2. 0/GLib. format_ size) instead of dividing by 1024