Merge lp:~alo21/pyjuju/fix-lp956000 into lp:pyjuju

[Alessandro Losavio]

Try to fix bug 956000

[Clint Byrum (clint-fewbar)]

Hello Alessandro, thanks for submitting this patch!

Unfortunately, this is not the right way to handle the problem. Printing down deep in classes is too low level and will not allow for graceful changes in the code and/or API later on. Also I suspect you'll get other errors because you don't raise an error (and therefore, the other code keeps executing).

The right way is probably to introduce a new error class, and then use a try/except in any call sites to handle it more gracefully.. like this:

try:
    whatever
except ThatError, e:
    sys.exit(e)

review: Needs Fixing

[Gustavo Niemeyer (niemeyer)]

Agreed, and the message should only be changed in the very specific case where "juju" is executed without any other arguments. It is really an error to interrupt whatever juju was going to do and stop to print that message.

review: Needs Fixing

Unmerged revisions

545. By Alessandro Losavio on 2012-06-24

fail to build from source

=== modified file 'juju/environment/config.py'
--- juju/environment/config.py	2012-04-11 01:17:53 +0000
+++ juju/environment/config.py	2012-06-24 17:03:19 +0000
@@ -229,9 +229,8 @@
             self.load()
         except FileNotFound:
             self.write_sample()
-            raise EnvironmentsConfigError("No environments configured. Please "
-                                          "edit: %s" % self.get_default_path(),
-                                          sample_written=True)
+            print("Info: %s does not exist, creating one. Please "
++                                          "edit: %s" % self.get_default_path(), self.get_default_path(), sample_written=True)
 
     def serialize(self, name=None):
         """Serialize the environments configuration.