Merge lp:~allison/ubuntu/precise/magics++/fix-misapplied-patch-and-linking into lp:ubuntu/precise/magics++

Proposed by Allison Randal
Status: Merged
Merged at revision: 15
Proposed branch: lp:~allison/ubuntu/precise/magics++/fix-misapplied-patch-and-linking
Merge into: lp:ubuntu/precise/magics++
Diff against target: 111 lines (+42/-17)
5 files modified
debian/as-needed.patch (+16/-16)
debian/changelog (+11/-0)
debian/patches/fix_libemos_link.patch (+13/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~allison/ubuntu/precise/magics++/fix-misapplied-patch-and-linking
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+85443@code.launchpad.net

Description of the change

Fix Precise FTBFS, update patch that no longer cleanly applied, and fix linking issues from --no-add-needed.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/as-needed.patch'
2--- debian/as-needed.patch 2011-09-13 13:45:47 +0000
3+++ debian/as-needed.patch 2011-12-13 08:32:27 +0000
4@@ -3,12 +3,12 @@
5 Note that this patch is applied by ./debian/rules AFTER autoreconf is run;
6 it cannot be applied in ./debian/patches
7 Bug-Debian: http://bugs.debian.org/347650
8-Last-Updated: 2011-09-13
9+Last-Updated: 2011-12-05
10 Forwarded: no
11
12---- ltmain.sh.orig 2011-09-13 10:05:45.000000000 +0100
13-+++ ltmain.sh 2011-09-13 10:22:40.000000000 +0100
14-@@ -5500,6 +5500,11 @@
15+--- ltmain.sh.orig 2011-12-05 23:13:53.614777184 +0000
16++++ ltmain.sh 2011-12-05 23:21:58.310794860 +0000
17+@@ -5512,6 +5512,11 @@
18 continue
19 ;;
20
21@@ -20,19 +20,19 @@
22 -export-symbols | -export-symbols-regex)
23 if test -n "$export_symbols" || test -n "$export_symbols_regex"; then
24 func_fatal_error "more than one -exported-symbols argument is not allowed"
25-@@ -6150,6 +6155,15 @@
26+@@ -6163,6 +6168,15 @@
27 lib=
28 found=no
29 case $deplib in
30-+ -Wl,--as-needed)
31-+ if test "$linkmode,$pass" = "prog,link"; then
32-+ compile_deplibs="$deplib $compile_deplibs"
33-+ finalize_deplibs="$deplib $finalize_deplibs"
34-+ else
35-+ deplibs="$deplib $deplibs"
36-+ fi
37-+ continue
38-+ ;;
39- -mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe|-threads)
40++ -Wl,--as-needed)
41++ if test "$linkmode,$pass" = "prog,link"; then
42++ compile_deplibs="$deplib $compile_deplibs"
43++ finalize_deplibs="$deplib $finalize_deplibs"
44++ else
45++ deplibs="$deplib $deplibs"
46++ fi
47++ continue
48++ ;;
49+ -mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe \
50+ |-threads|-fopenmp|-openmp|-mp|-xopenmp|-omp|-qsmp=*)
51 if test "$linkmode,$pass" = "prog,link"; then
52- compile_deplibs="$deplib $compile_deplibs"
53
54=== modified file 'debian/changelog'
55--- debian/changelog 2011-10-20 10:40:35 +0000
56+++ debian/changelog 2011-12-13 08:32:27 +0000
57@@ -1,3 +1,14 @@
58+magics++ (2.12.9-5ubuntu1) precise; urgency=low
59+
60+ * Update debian/as-needed.patch so it applies to changed
61+ config/ltmain.sh.
62+ * debian/rules: Add "-lm -lquadmath -lgfortran" to LIBS in configure
63+ line to directly link libraries that are needed.
64+ * Add debian/patches/fix_libemos_link.patch to link
65+ "-lquadmath -lgfortran".
66+
67+ -- Allison Randal <allison@canonical.com> Mon, 12 Dec 2011 23:18:31 -0800
68+
69 magics++ (2.12.9-5) unstable; urgency=low
70
71 * Recommends: pkg-config in -dev package.
72
73=== added file 'debian/patches/fix_libemos_link.patch'
74--- debian/patches/fix_libemos_link.patch 1970-01-01 00:00:00 +0000
75+++ debian/patches/fix_libemos_link.patch 2011-12-13 08:32:27 +0000
76@@ -0,0 +1,13 @@
77+Index: ftbfs-precise-trois/configure.ac
78+===================================================================
79+--- ftbfs-precise-trois.orig/configure.ac 2011-12-13 07:14:42.578672000 +0000
80++++ ftbfs-precise-trois/configure.ac 2011-12-13 07:16:57.793889070 +0000
81+@@ -768,7 +768,7 @@
82+ AC_SUBST(cairo)
83+
84+ # Add dynamic libs needed by Debian
85+-LIBS="$CAIRO_LIBS $LIBS -lemosR64 -lgrib_api -lterralib -lstdc++ -lm $NETCDF_LIBS"
86++LIBS="$CAIRO_LIBS $LIBS -lemosR64 -lgrib_api -lterralib -lstdc++ -lm -lquadmath -lgfortran $NETCDF_LIBS"
87+ LDFLAGS="$CAIRO_LDFLAGS $LDFLAGS -Wl,--as-needed"
88+
89+ # Autoheader
90
91=== modified file 'debian/patches/series'
92--- debian/patches/series 2011-09-13 13:45:47 +0000
93+++ debian/patches/series 2011-12-13 08:32:27 +0000
94@@ -4,3 +4,4 @@
95 enable_static.patch
96 debian-changes-2.12.9-2
97 debian-changes-2.12.9-3
98+fix_libemos_link.patch
99
100=== modified file 'debian/rules'
101--- debian/rules 2011-09-24 15:05:00 +0000
102+++ debian/rules 2011-12-13 08:32:27 +0000
103@@ -37,7 +37,7 @@
104 dh_auto_configure -- \
105 --enable-bufr --enable-static --enable-cairo --with-emos-libraries=/usr/lib \
106 --with-terralib=/usr --enable-python \
107- LDFLAGS="-L$(shell pwd)/src/.libs -Wl,--as-needed" LIBS=" -lX11 -lpng12 -lz"
108+ LDFLAGS="-L$(shell pwd)/src/.libs -Wl,--as-needed" LIBS=" -lX11 -lm -lquadmath -lgfortran -lpng12 -lz"
109
110 override_dh_auto_test check:
111 echo "Tests disabled; see README-testfailures.txt for details"

Subscribers

People subscribed via source and target branches