Merge lp:~allenap/tarmac/fix-votes-copyright into lp:tarmac
Proposed by
Gavin Panella
on 2010-09-09
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer on 2010-09-09 |
| Approved revision: | 352 |
| Merged at revision: | 352 |
| Proposed branch: | lp:~allenap/tarmac/fix-votes-copyright |
| Merge into: | lp:tarmac |
| Diff against target: |
56 lines (+19/-7) 2 files modified
tarmac/plugins/tests/test_votes.py (+17/-4) tarmac/plugins/votes.py (+2/-3) |
| To merge this branch: | bzr merge lp:~allenap/tarmac/fix-votes-copyright |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | 2010-09-09 | Approve on 2010-09-09 | |
|
Review via email:
|
|||
Commit Message
Change Copyright notices, fix small test issues.
Description of the Change
Bjorn noticed that I hadn't set the copyright notice in the votes plugin (and its tests) correctly. I wrote it on work time so I've changed it to attribute copyright to Canonical. Is that okay?
I also smuggled a fix to one of the tests to use self.fail() instead of raising AssertionError, inspired from reading one of jml's recent blog posts.
To post a comment you must log in.
lp:~allenap/tarmac/fix-votes-copyright
updated
on 2010-09-09
- 352. By Gavin Panella on 2010-09-09
-
Merge trunk, resolving 1 conflict.
review:
Approve
