Merge lp:~allenap/rabbitfixture/remove-service-config-bug-803043 into lp:rabbitfixture

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: 17
Merged at revision: 16
Proposed branch: lp:~allenap/rabbitfixture/remove-service-config-bug-803043
Merge into: lp:rabbitfixture
Diff against target: 72 lines (+1/-25)
3 files modified
rabbitfixture/server.py (+0/-11)
rabbitfixture/tests/test_server.py (+0/-13)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~allenap/rabbitfixture/remove-service-config-bug-803043
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+66903@code.launchpad.net

Commit message

Remove service_config and bump the version to 0.2.

Description of the change

Removes service_config and bumps the version to 0.2.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rabbitfixture/server.py'
2--- rabbitfixture/server.py 2011-06-30 11:50:40 +0000
3+++ rabbitfixture/server.py 2011-07-05 13:49:38 +0000
4@@ -14,7 +14,6 @@
5 import signal
6 import socket
7 import subprocess
8-from textwrap import dedent
9 import time
10
11 from amqplib import client_0_8 as amqp
12@@ -111,16 +110,6 @@
13 self.mnesiadir = self.useFixture(TempDir()).path
14 self.logfile = os.path.join(self.homedir, 'server.log')
15 self.nodename = os.path.basename(self.useFixture(TempDir()).path)
16- # XXX: GavinPanella 2011-06-28 bug=???: There is a (launchpad
17- # specific) config fixture. This should be a separate class in the
18- # Launchpad tree.
19- self.service_config = dedent("""\
20- [rabbitmq]
21- host: localhost:%d
22- userid: guest
23- password: guest
24- virtual_host: /
25- """ % self.port)
26
27 @property
28 def fq_nodename(self):
29
30=== modified file 'rabbitfixture/tests/test_server.py'
31--- rabbitfixture/tests/test_server.py 2011-06-28 14:23:36 +0000
32+++ rabbitfixture/tests/test_server.py 2011-07-05 13:49:38 +0000
33@@ -6,7 +6,6 @@
34 __metaclass__ = type
35
36 import socket
37-from textwrap import dedent
38
39 from amqplib import client_0_8 as amqp
40 from fixtures import EnvironmentVariableFixture
41@@ -36,18 +35,6 @@
42 # Which shouldn't blow up on iteration.
43 list(log.iter_text())
44
45- # XXX: GavinPanella 2011-06-28 bug=???: There is a (launchpad
46- # specific) config fixture. This should be a separate class in the
47- # Launchpad tree.
48- expected = dedent("""\
49- [rabbitmq]
50- host: localhost:%d
51- userid: guest
52- password: guest
53- virtual_host: /
54- """ % fixture.config.port)
55- self.assertEqual(expected, fixture.config.service_config)
56-
57 fixture.cleanUp()
58
59 # The daemon should be closed now.
60
61=== modified file 'setup.py'
62--- setup.py 2011-06-30 13:28:10 +0000
63+++ setup.py 2011-07-05 13:49:38 +0000
64@@ -6,7 +6,7 @@
65
66 setup(
67 name='rabbitfixture',
68- version="0.1",
69+ version="0.2",
70 packages=find_packages('.'),
71 package_dir={'': '.'},
72 include_package_data=True,

Subscribers

People subscribed via source and target branches

to all changes: