Code review comment for lp:~allenap/rabbitfixture/rabbitmq-3.3-and-later

Revision history for this message
Gavin Panella (allenap) wrote :

> Thanks for solving this mystery! Impressive diagnostic work.
> EnvironmentVariableFixture is starting to look a bit tedious — if only it'd
> take a dict, or **kwargs...

That's Daniel Widerin's work; I take no credit.

>
> One suggestion for the branch: if the test verified that the port numbers were
> in range, might that not have revealed this problem earlier on?

No. This is a new setting, one which rabbitfixture was unaware of. RabbitMQ itself defaults the dist port to node port + 20000. I assume there's an internal overflow there.

Thanks for the review.

« Back to merge proposal