Merge lp:~allenap/maas/utf8-before-urlencode into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1087 |
Proposed branch: | lp:~allenap/maas/utf8-before-urlencode |
Merge into: | lp:~maas-committers/maas/trunk |
Prerequisite: | lp:~allenap/maas/urlencode-is-duckist |
Diff against target: |
103 lines (+47/-1) 3 files modified
src/maascli/api.py (+1/-1) src/maascli/tests/test_utils.py (+28/-0) src/maascli/utils.py (+18/-0) |
To merge this branch: | bzr merge lp:~allenap/maas/utf8-before-urlencode |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Review via email: mp+126587@code.launchpad.net |
Commit message
Always UTF-8 encode Unicode strings before URL encoding them.
The standard library's urllib.urlencode is not Unicode safe. This new version is, and is round-trip tested with Django's stated query string handling policy.
To post a comment you must log in.
No proposals found for merge of lp:~allenap/maas/urlencode-is-duckist into lp:maas.