Merge lp:~allenap/maas/unreliable-test--bug-1308069 into lp:~maas-committers/maas/trunk

[Gavin Panella]

Reenable test_prepare_holds_startup_lock.

Reproducing the spurious failure was not possible. Reintroducing it to the test suite will again expose it to a more varied environment, with the hope that we learn how to reproduce it should it happen again.

[Gavin Panella (allenap)]

review: Approve

[Andres Rodriguez (andreserl)]

Please also backport the enablement to 1.5 as this Jason initially
backported skipping this test.
On Apr 15, 2014 4:40 PM, "Gavin Panella" <email address hidden>
wrote:

> Gavin Panella has proposed merging
> lp:~allenap/maas/unreliable-test--bug-1308069 into lp:maas.
>
> Commit message:
> Reenable test_prepare_holds_startup_lock.
>
> Reproducing the spurious failure was not possible. Reintroducing it to the
> test suite will again expose it to a more varied environment, with the hope
> that we learn how to reproduce it should it happen again.
>
> Requested reviews:
> MAAS Maintainers (maas-maintainers)
> Related bugs:
> Bug #1308069 in MAAS: "test_prepare_holds_startup_lock() fails
> spuriously"
> https://bugs.launchpad.net/maas/+bug/1308069
>
> For more details, see:
>
> https://code.launchpad.net/~allenap/maas/unreliable-test--bug-1308069/+merge/215952
> --
>
> https://code.launchpad.net/~allenap/maas/unreliable-test--bug-1308069/+merge/215952
> You are subscribed to branch lp:maas.
>
> === modified file 'src/maasserver/rpc/tests/test_regionservice.py'
> --- src/maasserver/rpc/tests/test_regionservice.py 2014-04-15
> 13:42:26 +0000
> +++ src/maasserver/rpc/tests/test_regionservice.py 2014-04-15
> 20:40:15 +0000
> @@ -82,7 +82,6 @@
> from twisted.internet.threads import deferToThread
> from twisted.protocols import amp
> from twisted.python import log
> -from unittest import skip
>
>
> class TestRegionProtocol_Identify(MAASTestCase):
> @@ -642,7 +641,6 @@
> cursor.execute("SELECT * FROM eventloops")
> self.assertEqual([], list(cursor))
>
> - @skip("XXX gmb 2014-04-15 bug=1308069: Fails spuriously.")
> def test_prepare_holds_startup_lock(self):
> # Creating tables in PostgreSQL is a transactional operation
> # like any other. If the isolation level is not sufficient - the
>
>
>

[Andres Rodriguez (andreserl)]

(Or well... Doesn't matter as 1.5 is released)
On Apr 15, 2014 4:42 PM, "Andres Rodriguez" <email address hidden> wrote:

> Please also backport the enablement to 1.5 as this Jason initially
> backported skipping this test.
> On Apr 15, 2014 4:40 PM, "Gavin Panella" <email address hidden>
> wrote:
>
> > Gavin Panella has proposed merging
> > lp:~allenap/maas/unreliable-test--bug-1308069 into lp:maas.
> >
> > Commit message:
> > Reenable test_prepare_holds_startup_lock.
> >
> > Reproducing the spurious failure was not possible. Reintroducing it to
> the
> > test suite will again expose it to a more varied environment, with the
> hope
> > that we learn how to reproduce it should it happen again.
> >
> > Requested reviews:
> > MAAS Maintainers (maas-maintainers)
> > Related bugs:
> > Bug #1308069 in MAAS: "test_prepare_holds_startup_lock() fails
> > spuriously"
> > https://bugs.launchpad.net/maas/+bug/1308069
> >
> > For more details, see:
> >
> >
> https://code.launchpad.net/~allenap/maas/unreliable-test--bug-1308069/+merge/215952
> > --
> >
> >
> https://code.launchpad.net/~allenap/maas/unreliable-test--bug-1308069/+merge/215952
> > You are subscribed to branch lp:maas.
> >
> > === modified file 'src/maasserver/rpc/tests/test_regionservice.py'
> > --- src/maasserver/rpc/tests/test_regionservice.py 2014-04-15
> > 13:42:26 +0000
> > +++ src/maasserver/rpc/tests/test_regionservice.py 2014-04-15
> > 20:40:15 +0000
> > @@ -82,7 +82,6 @@
> > from twisted.internet.threads import deferToThread
> > from twisted.protocols import amp
> > from twisted.python import log
> > -from unittest import skip
> >
> >
> > class TestRegionProtocol_Identify(MAASTestCase):
> > @@ -642,7 +641,6 @@
> > cursor.execute("SELECT * FROM eventloops")
> > self.assertEqual([], list(cursor))
> >
> > - @skip("XXX gmb 2014-04-15 bug=1308069: Fails spuriously.")
> > def test_prepare_holds_startup_lock(self):
> > # Creating tables in PostgreSQL is a transactional operation
> > # like any other. If the isolation level is not sufficient - the
> >
> >
> >
>
> --
>
> https://code.launchpad.net/~allenap/maas/unreliable-test--bug-1308069/+merge/215952
> You are subscribed to branch lp:maas.
>

=== modified file 'src/maasserver/rpc/tests/test_regionservice.py'
--- src/maasserver/rpc/tests/test_regionservice.py	2014-04-15 13:42:26 +0000
+++ src/maasserver/rpc/tests/test_regionservice.py	2014-04-15 20:40:15 +0000
@@ -82,7 +82,6 @@
 from twisted.internet.threads import deferToThread
 from twisted.protocols import amp
 from twisted.python import log
-from unittest import skip
 
 
 class TestRegionProtocol_Identify(MAASTestCase):
@@ -642,7 +641,6 @@
                 cursor.execute("SELECT * FROM eventloops")
                 self.assertEqual([], list(cursor))
 
-    @skip("XXX gmb 2014-04-15 bug=1308069: Fails spuriously.")
     def test_prepare_holds_startup_lock(self):
         # Creating tables in PostgreSQL is a transactional operation
         # like any other. If the isolation level is not sufficient - the