Merge lp:~allenap/maas/spurious-compose-preseed-test into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5867 |
Proposed branch: | lp:~allenap/maas/spurious-compose-preseed-test |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
55 lines (+7/-2) 3 files modified
src/maasserver/forms/tests/test_interface.py (+2/-0) src/maasserver/models/tests/test_iprange.py (+2/-0) src/maasserver/tests/test_compose_preseed.py (+3/-2) |
To merge this branch: | bzr merge lp:~allenap/maas/spurious-compose-preseed-test |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Lee Trager | Pending | ||
Review via email: mp+321270@code.launchpad.net |
Commit message
Fix spurious failures in test_compose_
Description of the change
This fixes errors like the following:
```
ERROR: maasserver.
.TestComposeP
.test_
-------
Traceback (most recent call last):
testtools.
Twisted logs
Traceback (most recent call last):
File "/tmp/tarmac/
result = function(*args, **kwargs)
File "/home/
return self._get_
File "/tmp/tarmac/
compose_
File "/tmp/tarmac/
return compose_
File "/tmp/tarmac/
poweroff_
File "/tmp/tarmac/
if script_
AttributeError: 'NoneType' object has no attribute 'power_
```
The test's setup contains:
node = factory.make_Node(
interface
This crash is only triggered when status=TESTING, so this branch removes
that choice. This unblocks others, but is probably not the right fix:
there's another bug to be fixed.
Self-review, but I'd like Lee to take a look too.