Code review comment for lp:~allenap/maas/repackage

Revision history for this message
Gavin Panella (allenap) wrote :

> Here's one thing I really don't like: I ran a plain "make" just now and found
> it went and sudo'ed on me.  I don't expect a build to mess with my global
> system configuration!

Something it could do, without needing root privileges, is to check if
all the dependencies are installed. If not, it can bail with a message

    The following system dependencies are missing:
    To install them, run the following command:
        sudo apt-get install ...

Would that be better?

Fwiw, I like the automatic installation, but I can see that it's not
going to be to everyone's tastes.

« Back to merge proposal