Code review comment for lp:~allenap/maas/remove-squashfs

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 14/11/12 03:55, Gavin Panella wrote:
> We need maas-import-pxe-files, -ephemerals and -isos, so we can't
> remove them. However, we don't *need* squashfs support, so we don't
> need maas-import-squashfs. Given that the feature does not work, and
> that it needs non-trivial investment to get it working and covered by
> tests, there's really no good argument for keeping it in trunk right
> now.

This is the key point for me. squashfs brings little relative
improvement for the amount of untested code that we're carrying to make
it happen. The risk of failure versus the return is quite bad.

We'll be very happy to work with the server team to make FPI well
engineered and tested.

« Back to merge proposal