MAAS

Merge lp:~allenap/maas/remove-nose-progressive into lp:~maas-committers/maas/trunk

  1. remove-nose-progressive
  2. Merge into trunk
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 5651
Proposed branch: lp:~allenap/maas/remove-nose-progressive
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 41 lines (+5/-7)
2 files modified
buildout.cfg (+5/-6)
versions.cfg (+0/-1)
To merge this branch: bzr merge lp:~allenap/maas/remove-nose-progressive
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+315333@code.launchpad.net

Commit message

Remove nose-progressive.

Rendering of tracebacks is broken in Python 3.5.

Description of the change

I abandoned an attempt to fix the broken rendering of tracebacks in the upstream nose-progressive project because tests do not pass cleanly in either Python 2.7 or 3.5 as it is. Even if we fix tracebacks we would probably encounter additional problems. This is a nice-to-have feature in MAAS that, for now, it seems we would be better off without.

It is still possible for individuals on the team to use this plug-in by installing it to their PYTHONPATH and passing --with-progressive to bin/test.* or by setting NOSE_WITH_PROGRESSIVE=1 in their environment.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'buildout.cfg'
2--- buildout.cfg 2017-01-20 11:30:38 +0000
3+++ buildout.cfg 2017-01-23 09:34:29 +0000
4@@ -39,7 +39,6 @@
5 hypothesis
6 ipdb
7 nose
8- nose-progressive
9 nose-timer
10 postgresfixture
11 python-subunit
12@@ -70,12 +69,12 @@
13 from warnings import filterwarnings
14 filterwarnings("ignore", category=RuntimeWarning, module="pkg_resources")
15 inject-test-options =
16- # When running tests from a console use the progressive output plugin.
17- # When running headless increase the verbosity so we can see the test
18- # being run from a log file. An `options` list must be defined ahead
19- # of the use of this snippet.
20+ # When running tests from a console show only dots, but when running
21+ # headless increase verbosity so we can see the test being run from a
22+ # log file. An `options` list must be defined ahead of the use of this
23+ # snippet.
24 options += (
25- ["--verbosity=0", "--with-progressive"]
26+ ["--verbosity=1"]
27 if sys.stdout.isatty() else
28 ["--verbosity=2"]
29 )
30
31=== modified file 'versions.cfg'
32--- versions.cfg 2017-01-20 11:30:38 +0000
33+++ versions.cfg 2017-01-23 09:34:29 +0000
34@@ -23,7 +23,6 @@
35 junitxml = 0.7
36 linecache2 = 1.0.0
37 nose = 1.3.7
38-nose-progressive = 1.5.1
39 nose-timer = 0.6.0
40 pbr = 1.10.0
41 pickleshare = 0.7.4