Merge lp:~allenap/maas/regiond-bind-on-all-interfaces into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Rejected |
---|---|
Rejected by: | MAAS Lander |
Proposed branch: | lp:~allenap/maas/regiond-bind-on-all-interfaces |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
296 lines (+64/-39) 8 files modified
src/maasserver/eventloop.py (+29/-10) src/maasserver/start_up.py (+2/-1) src/maasserver/tests/test_eventloop.py (+3/-6) src/maasserver/tests/test_plugin.py (+5/-1) src/maasserver/tests/test_start_up.py (+3/-2) src/maasserver/tests/test_webapp.py (+15/-12) src/maasserver/webapp.py (+2/-4) src/maastesting/protractor/runner.py (+5/-3) |
To merge this branch: | bzr merge lp:~allenap/maas/regiond-bind-on-all-interfaces |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike Pontillo (community) | Abstain | ||
Review via email: mp+252159@code.launchpad.net |
Commit message
Bind the web application on all IPv4 and IPv6 interfaces.
Previously only IPv4 interfaces were bound.
Description of the change
This is a resurrected old branch that I never quite finished.
To post a comment you must log in.
Unmerged revisions
- 3514. By Gavin Panella
-
Get things working.
- 3513. By Gavin Panella
-
Merge trunk, resolving lots of conflicts.
- 3512. By Gavin Panella
-
Bind an AF_INET6 socket to '::', which should provide IPv4 compatibility.
- 3511. By Gavin Panella
-
Merge trunk, resolving conflicts.
- 3510. By Gavin Panella
-
Run start_up() before starting *any* services.
- 3509. By Gavin Panella
-
Use @transactional so that serialization failures are retried.
- 3508. By Gavin Panella
-
Remove DEFAULT_PORT.
- 3507. By Gavin Panella
-
Merge trunk, resolving conflicts.
- 3506. By Gavin Panella
-
Merge trunk.
- 3505. By Gavin Panella
-
Bind the webapp to all interfaces.
This is a little strange to me. Usually IPv6 sockets operate in IPv4-compatability mode, and all a service has to do in order to listen on *both* IPv4 and IPv6 sockets is to bind to `::`. So this branch looks like it may be more complex than needed. However, I haven't investigated how Twisted does it (and the Python code *may* be setting socket options that disable IPv4-compatibility within IPv6). So I neither approve nor disapprove, but I think it warrants more investigation.