Merge lp:~allenap/maas/packaging.remove-maas into lp:~maas-maintainers/maas/packaging

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: 541
Merged at revision: 537
Proposed branch: lp:~allenap/maas/packaging.remove-maas
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 55 lines (+6/-9)
4 files modified
debian/changelog (+3/-0)
debian/extras/maas-region (+2/-4)
debian/maas-region-api.install (+0/-3)
debian/maas-region-api.maas-regiond-worker@.service (+1/-2)
To merge this branch: bzr merge lp:~allenap/maas/packaging.remove-maas
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+312330@code.launchpad.net

Commit message

Don't install Django settings into /usr/share/maas/maas.

For regiond these were squatting the `maas` namespace, preventing its use elsewhere.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :
Revision history for this message
Blake Rouse (blake-rouse) wrote :

What about the upgrade path? Will the /usr/share/maas/maas be removed?

review: Needs Information
Revision history for this message
Gavin Panella (allenap) wrote :

> What about the upgrade path? Will the /usr/share/maas/maas be removed?

I tried this out on my NUCs and /usr/share/maas/maas was removed, I assume by the default packaging machinery.

Revision history for this message
Blake Rouse (blake-rouse) wrote :

Perfect!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-11-22 01:03:30 +0000
3+++ debian/changelog 2016-12-02 09:33:29 +0000
4@@ -1,6 +1,9 @@
5 maas (2.2.0~alpha1+bzr5562-0ubuntu1) UNRELEASED; urgency=medium
6
7 * UNRELEASED
8+ - Don't install Django settings into /usr/share/maas/maas. For
9+ regiond these were squatting the `maas` namespace, preventing its
10+ use elsewhere (LP: 1646748)
11
12 -- Andres Rodriguez <andreserl@ubuntu.com> Mon, 21 Nov 2016 20:01:31 -0500
13
14
15=== modified file 'debian/extras/maas-region'
16--- debian/extras/maas-region 2016-03-07 22:01:56 +0000
17+++ debian/extras/maas-region 2016-12-02 09:33:29 +0000
18@@ -41,10 +41,8 @@
19
20 def run():
21 # Force the production MAAS Django configuration.
22- os.environ.setdefault("DJANGO_SETTINGS_MODULE", "maas.settings")
23-
24- # The Django configuration lives outside of sys.path.
25- sys.path.append('/usr/share/maas')
26+ os.environ.setdefault(
27+ "DJANGO_SETTINGS_MODULE", "maasserver.djangosettings.settings")
28
29 # Let Django do the rest.
30 from django.core import management
31
32=== modified file 'debian/maas-region-api.install'
33--- debian/maas-region-api.install 2016-09-01 14:56:04 +0000
34+++ debian/maas-region-api.install 2016-12-02 09:33:29 +0000
35@@ -1,6 +1,3 @@
36-# Install project
37-debian/tmp/usr/lib/python*/dist-packages/maas usr/share/maas
38-
39 # Install static files
40 debian/tmp/usr/share/maas/web/static
41
42
43=== modified file 'debian/maas-region-api.maas-regiond-worker@.service'
44--- debian/maas-region-api.maas-regiond-worker@.service 2016-11-08 16:16:57 +0000
45+++ debian/maas-region-api.maas-regiond-worker@.service 2016-12-02 09:33:29 +0000
46@@ -13,8 +13,7 @@
47 Restart=always
48 RestartSec=10s
49 Environment="MAAS_REGIOND_WORKER_ID=%i"
50-Environment="DJANGO_SETTINGS_MODULE=maas.settings"
51-Environment="PYTHONPATH=/usr/share/maas"
52+Environment="DJANGO_SETTINGS_MODULE=maasserver.djangosettings.settings"
53 Environment="LOGFILE=/var/log/maas/regiond.log"
54 # Logs go to the journal; read them with:
55 # journalctl -u maas-regiond-worker@*

Subscribers

People subscribed via source and target branches