Merge lp:~allenap/maas/packaging.move-dhcp-helper-to-lib into lp:~maas-maintainers/maas/packaging

Proposed by Gavin Panella
Status: Rejected
Rejected by: Gavin Panella
Proposed branch: lp:~allenap/maas/packaging.move-dhcp-helper-to-lib
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 68 lines (+6/-5)
6 files modified
debian/changelog (+1/-0)
debian/maas-dhcp.apparmor (+1/-1)
debian/maas-dhcp.maas-dhcpd.service (+1/-1)
debian/maas-dhcp.maas-dhcpd6.service (+1/-1)
debian/maas-rack-controller.install (+1/-1)
debian/maas-rack-controller.lintian-overrides (+1/-1)
To merge this branch: bzr merge lp:~allenap/maas/packaging.move-dhcp-helper-to-lib
Reviewer Review Type Date Requested Status
Blake Rouse (community) Needs Information
Review via email: mp+321521@code.launchpad.net

Commit message

Move maas-dhcp-helper off PATH to /usr/lib/maas.

Description of the change

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Again just thought of the reason this might be a problem. Check other branch for reason. A symlink might be needed in this branch and the apparmor conf would need to have both paths.

review: Needs Information
Revision history for this message
Gavin Panella (allenap) wrote :

Unmerged revisions

552. By Gavin Panella

Move maas-dhcp-helper off PATH to /usr/lib/maas.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2017-03-28 19:33:49 +0000
3+++ debian/changelog 2017-03-31 08:10:23 +0000
4@@ -3,6 +3,7 @@
5 * New upstream release, MAAS 2.2.0 Beta 5.
6 * debian/maas-common.logrotate: Rotate maas.log weekly, instead of daily.
7 Store logs for 8 weeks. (LP: #1677005)
8+ * Move maas-dhcp-helper off PATH to /usr/lib/maas.
9
10 -- Andres Rodriguez <andreserl@ubuntu.com> Tue, 28 Mar 2017 11:08:38 -0400
11
12
13=== modified file 'debian/maas-dhcp.apparmor'
14--- debian/maas-dhcp.apparmor 2016-03-29 20:32:33 +0000
15+++ debian/maas-dhcp.apparmor 2017-03-31 08:10:23 +0000
16@@ -6,5 +6,5 @@
17 /var/lib/maas/dhcp/dhcpd*.leases* lrw,
18 /var/lib/maas/dhcpd.conf r,
19 /var/lib/maas/dhcpd6.conf r,
20-/usr/sbin/maas-dhcp-helper Ux,
21+/usr/lib/maas/maas-dhcp-helper Ux,
22 /tmp/maas-dhcpd-* r,
23
24=== modified file 'debian/maas-dhcp.maas-dhcpd.service'
25--- debian/maas-dhcp.maas-dhcpd.service 2016-03-22 17:07:45 +0000
26+++ debian/maas-dhcp.maas-dhcpd.service 2017-03-31 08:10:23 +0000
27@@ -18,7 +18,7 @@
28 INTERFACES=$(cat /var/lib/maas/dhcpd-interfaces); \
29 LEASES_FILE=/var/lib/maas/dhcp/dhcpd.leases; \
30 [ -e $LEASES_FILE ] || touch $LEASES_FILE; \
31- /usr/sbin/maas-dhcp-helper clean $LEASES_FILE; \
32+ /usr/lib/maas/maas-dhcp-helper clean $LEASES_FILE; \
33 chown root:dhcpd /var/lib/maas/dhcp $LEASES_FILE; \
34 chmod 775 /var/lib/maas/dhcp ; chmod 664 $LEASES_FILE; \
35 exec dhcpd -user dhcpd -group dhcpd -f -q -4 -pf /run/maas/dhcp/dhcpd.pid \
36
37=== modified file 'debian/maas-dhcp.maas-dhcpd6.service'
38--- debian/maas-dhcp.maas-dhcpd6.service 2016-04-22 23:27:40 +0000
39+++ debian/maas-dhcp.maas-dhcpd6.service 2017-03-31 08:10:23 +0000
40@@ -18,7 +18,7 @@
41 INTERFACES=$(cat /var/lib/maas/dhcpd6-interfaces); \
42 LEASES_FILE=/var/lib/maas/dhcp/dhcpd6.leases; \
43 [ -e $LEASES_FILE ] || touch $LEASES_FILE; \
44- /usr/sbin/maas-dhcp-helper clean $LEASES_FILE; \
45+ /usr/lib/maas/maas-dhcp-helper clean $LEASES_FILE; \
46 chown root:dhcpd /var/lib/maas/dhcp $LEASES_FILE; \
47 chmod 775 /var/lib/maas/dhcp ; chmod 664 $LEASES_FILE; \
48 exec dhcpd -user dhcpd -group dhcpd -f -6 -pf /run/maas/dhcp/dhcpd6.pid \
49
50=== modified file 'debian/maas-rack-controller.install'
51--- debian/maas-rack-controller.install 2017-03-23 21:31:18 +0000
52+++ debian/maas-rack-controller.install 2017-03-31 08:10:23 +0000
53@@ -2,7 +2,7 @@
54 debian/tmp/usr/bin/uec2roottar
55
56 # Install maas-dhcp-helper
57-debian/tmp/usr/sbin/maas-dhcp-helper
58+debian/tmp/usr/lib/maas/maas-dhcp-helper
59
60 # Install network monitoring scripts
61 debian/tmp/usr/lib/maas/maas-network-monitor
62
63=== modified file 'debian/maas-rack-controller.lintian-overrides'
64--- debian/maas-rack-controller.lintian-overrides 2017-03-23 21:31:18 +0000
65+++ debian/maas-rack-controller.lintian-overrides 2017-03-31 08:10:23 +0000
66@@ -1,1 +1,1 @@
67-maas-rack-controller: binary-without-manpage usr/bin/uec2roottar usr/sbin/maas-dhcp-helper usr/lib/maas/maas-network-monitor usr/lib/maas/maas-dhcp-monitor
68+maas-rack-controller: binary-without-manpage usr/bin/uec2roottar usr/lib/maas/maas-dhcp-helper usr/lib/maas/maas-dhcp-monitor usr/lib/maas/maas-network-monitor

Subscribers

People subscribed via source and target branches