Merge lp:~allenap/maas/packaging.fix-patch-02 into lp:~maas-maintainers/maas/packaging

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: 340
Merged at revision: 341
Proposed branch: lp:~allenap/maas/packaging.fix-patch-02
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 41 lines (+6/-13)
1 file modified
debian/patches/02-pserv-config.patch (+6/-13)
To merge this branch: bzr merge lp:~allenap/maas/packaging.fix-patch-02
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Raphaël Badin (community) Approve
Review via email: mp+246544@code.launchpad.net

Commit message

Fixes a patch that no longer applies cleanly because the OOPS section in the config file was removed.

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

It looks good: it applies cleanly now.

Now, I'm told it cannot be avoided but it's painful to get these silly questions about config files I didn't touch when upgrading: http://paste.ubuntu.com/9754896/

I'm +1 on this (since it fixes my immediate problem). But maybe it's worth Andres having a look at this.

(Also, IIRC you need a changelog entry for this)

review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

Thanks. I'll wait for roaksoax to comment too before I land.

Revision history for this message
Andres Rodriguez (andreserl) :
review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

@Andres: don't we need a changelog entry for this?

Revision history for this message
Gavin Panella (allenap) wrote :

I don't think it needs a changelog entry. It's just a repair, not a change that anyone's going want to read about.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/02-pserv-config.patch'
2--- debian/patches/02-pserv-config.patch 2014-03-28 06:50:05 +0000
3+++ debian/patches/02-pserv-config.patch 2015-01-15 10:09:46 +0000
4@@ -3,8 +3,9 @@
5 include port, logfile, oops directory, cobbler url and username
6 Author: Andres Rodriguez <andreserl@ubuntu.com>
7
8---- a/etc/maas/pserv.yaml
9-+++ b/etc/maas/pserv.yaml
10+=== modified file 'etc/maas/pserv.yaml'
11+--- a/etc/maas/pserv.yaml 2015-01-14 16:24:44 +0000
12++++ b/etc/maas/pserv.yaml 2015-01-15 10:05:50 +0000
13 @@ -6,7 +6,7 @@
14 ## running server.
15 #
16@@ -12,18 +13,9 @@
17 -logfile: "/dev/null"
18 +logfile: "/var/log/maas/pserv.log"
19
20- ## OOPS configuration (optional).
21+ ## TFTP configuration.
22 #
23-@@ -15,7 +15,7 @@
24- # or directories other than what the oops machinery creates there.
25- #
26- # directory:
27-- directory: "logs/oops"
28-+ directory: "/var/log/maas/oops"
29- # reporter:
30- reporter: "maas-pserv"
31-
32-@@ -38,8 +38,6 @@
33+@@ -18,8 +18,6 @@
34 # resource_root: /var/lib/maas/boot-resources/current/
35
36 # port: 69
37@@ -32,3 +24,4 @@
38 # generator: http://localhost/MAAS/api/1.0/pxeconfig/
39 - generator: http://localhost:5243/api/1.0/pxeconfig/
40
41+

Subscribers

People subscribed via source and target branches