Merge lp:~allenap/maas/no-typing-in-zesty into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5614 |
Proposed branch: | lp:~allenap/maas/no-typing-in-zesty |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
74 lines (+29/-10) 2 files modified
src/maastesting/typecheck.py (+21/-0) src/provisioningserver/boot/__init__.py (+8/-10) |
To merge this branch: | bzr merge lp:~allenap/maas/no-typing-in-zesty |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lee Trager (community) | Approve | ||
Review via email: mp+313350@code.launchpad.net |
Commit message
Disable type checks when subclass checks do not work with type hints.
Zesty has introduced a subtly new version of `typing` in which Union and its derivatives no longer work with issubclass.
Description of the change
See bug 1650202 for the impetus.
To post a comment you must log in.
I suppose we should wait for the bug to be closed as Invalid/Won't fix before merging this, but otherwise it seems a sensible, if unfortunate, way to work around this.