MAAS

Merge lp:~allenap/maas/ipmi-import-glob-1.4 into lp:maas/1.4

  1. ipmi-import-glob-1.4
  2. Merge into 1.4
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 1718
Proposed branch: lp:~allenap/maas/ipmi-import-glob-1.4
Merge into: lp:maas/1.4
Diff against target: 9 lines (+1/-0)
1 file modified
etc/maas/templates/commissioning-user-data/snippets/maas_ipmi_autodetect_tool.py (+1/-0)
To merge this branch: bzr merge lp:~allenap/maas/ipmi-import-glob-1.4
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Approve
Review via email: mp+213911@code.launchpad.net

Commit message

Fix missing import in commissioning snippet.

Description of the change

This has been fixed in trunk and 1.5. It's a wonder how it's slipped our notice for so long in Saucy.

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

Looks good. I forget how the SRU process works but I *think* this fix should be linked to a critical bug targeting Saucy so that we can pass this on to the server guys.

This is a real-world occurrence of the error https://www.dropbox.com/s/j770hq7thqqxmnc/Screenshot%202014-04-02%2011.37.56.png with MAAS version 1.4+bzr1693+dfsg-0ubuntu2.3.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etc/maas/templates/commissioning-user-data/snippets/maas_ipmi_autodetect_tool.py'
2--- etc/maas/templates/commissioning-user-data/snippets/maas_ipmi_autodetect_tool.py 2013-10-09 14:37:13 +0000
3+++ etc/maas/templates/commissioning-user-data/snippets/maas_ipmi_autodetect_tool.py 2014-04-02 19:19:40 +0000
4@@ -1,5 +1,6 @@
5 #!/usr/bin/python
6 import commands
7+import glob
8 import subprocess
9 import re
10

Subscribers

People subscribed via source and target branches

to all changes: