Merge lp:~allenap/maas/finding-something-that-should-not-be-there--bug-1659244 into lp:~maas-committers/maas/trunk

[Gavin Panella]

Fix a couple of spuriously failing tests.

They had been assuming an empty database, but tests now run in a fully-migrated database which happens to contain a couple of package repositories. A non-existing repository ID was being chosen at random but about 2% of the time it did exist.

[Gavin Panella (allenap)]

review: Approve

=== modified file 'src/maasserver/api/tests/test_packagerepositories.py'
--- src/maasserver/api/tests/test_packagerepositories.py	2017-01-11 15:24:56 +0000
+++ src/maasserver/api/tests/test_packagerepositories.py	2017-01-25 10:41:02 +0000
@@ -65,9 +65,10 @@
             parsed_package_repository.keys())
 
     def test_read_404_when_bad_id(self):
+        most_recent_repo = PackageRepository.objects.latest("id")
         response = self.client.get(
             reverse(
-                'package_repository_handler', args=[random.randint(0, 100)]))
+                'package_repository_handler', args=[most_recent_repo.id + 1]))
         self.assertEqual(
             http.client.NOT_FOUND, response.status_code, response.content)
 
@@ -120,10 +121,11 @@
         self.assertIsNotNone(reload_object(package_repository))
 
     def test_delete_404_when_invalid_id(self):
+        most_recent_repo = PackageRepository.objects.latest("id")
         self.become_admin()
         response = self.client.delete(
             reverse(
-                'package_repository_handler', args=[random.randint(0, 100)]))
+                'package_repository_handler', args=[most_recent_repo.id + 1]))
         self.assertEqual(
             http.client.NOT_FOUND, response.status_code, response.content)