Code review comment for lp:~allenap/maas/find-nodegroup-redux

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Very nice branch! Clear code, clear commenting and very easy to follow. Great work.

225 + def test_more_than_1_unmanaged_interface(self):
226 + nodegroup1 = factory.make_node_group(
227 + management=NODEGROUPINTERFACE_MANAGEMENT.UNMANAGED,
228 + network=IPNetwork("192.168.41.0/16"))
229 + nodegroup2 = factory.make_node_group(
230 + management=NODEGROUPINTERFACE_MANAGEMENT.UNMANAGED,
231 + network=IPNetwork("192.168.41.0/24"))
232 + self.assertIn(
233 + find_nodegroup(get_request('192.168.41.199')),
234 + {nodegroup1, nodegroup2})

Since the query to find the interfaces is deterministic, should it check for a particular nodegroup?

review: Approve

« Back to merge proposal