Merge lp:~allenap/maas/effing-download-cache into lp:maas/trunk

[Gavin Panella]

Remove need for faulty bootstrap.py by install zc.buildout into a virtualenv.

This removes the need for the faulty zc.buildout bootstrap.py script. Instead it creates a virtualenv and uses pip to install zc.buildout from source.

Part of this required removing the allowed-eggs-from-site-packages setting in buildout.cfg. This isn't really needed - I think we always want to use the system package if it's available - and I believe this option won't be available in buildout 2. If we need to test using a package version different to the system package it can be installed using pip.

[Raphaël Badin (rvb)]

I can't say I'm an expert on this but I think this looks good.

We would clearly be better off if we could get rid of buildout (but is there a decent alternative? pip+virtualenv?). This seems like a first step.

[0]

33 + $ sudo apt-get install python-sphinx python-lxml python-pocket-lint \
34 + python-pip python-virtualenv

70 + bin/pip --quiet install bootstrap/zc.buildout-1.5.2.tar.gz

Would it be possible to add 'python-zc.buildout' to the list of required packages and install it from the system's package rather that from a file in our tree?

[1]

44 +buildout := bin/buildout $(shell tty -s && echo -D)

Can you explain why this is needed?

review: Approve

[lp:~allenap/maas/effing-download-cache]

646. By Gavin Panella on 2012-06-15

Force install zc.buildout from source, so that we can be sure to get the bin/buildout script.

647. By Gavin Panella on 2012-06-15

Don't automatically open the post-mortem debugger when buildout goes wrong.

[Gavin Panella (allenap)]

> [0]
>
> 33 + $ sudo apt-get install python-sphinx python-lxml python-pocket-
> lint \
> 34 + python-pip python-virtualenv
>
> 70 + bin/pip --quiet install bootstrap/zc.buildout-1.5.2.tar.gz
>
> Would it be possible to add 'python-zc.buildout' to the list of required
> packages and install it from the system's package rather that from a file in
> our tree?

It doesn't quite work. We currently rely on the bin/buildout script.
We need to force the installation (change just pushed) so that this
script is created. In any case, zc.buildout-1.5.2.tar.gz is only
324kB, and we'll get rid of it soon I hope :)

>
> [1]
>
> 44 +buildout := bin/buildout $(shell tty -s && echo -D)
>
> Can you explain why this is needed?

This is something I left it from testing. It just enabled post-mortem
debugging if it's invoked from an interactive terminal.

Thanks for the review!