Merge lp:~allenap/maas/database-locks-revisited into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2395 |
Proposed branch: | lp:~allenap/maas/database-locks-revisited |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
166 lines (+52/-8) 4 files modified
src/maasserver/rpc/regionservice.py (+1/-1) src/maasserver/rpc/tests/test_regionservice.py (+2/-4) src/maasserver/utils/dblocks.py (+31/-2) src/maasserver/utils/tests/test_dblocks.py (+18/-1) |
To merge this branch: | bzr merge lp:~allenap/maas/database-locks-revisited |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+221762@code.launchpad.net |
Commit message
Tighten up function and use of DatabaseLock.
Previously Django's aggressive connection closing policy would prevent session-level locks from being maintained.
To post a comment you must log in.
Thanks for fixing this. One of those little things that kept us awake at night.
Two small things: in the test names, "crashes" sounds overly unintentional. Why not "raises" or "fails"? Or even just "checks that"?