Merge lp:~allenap/maas/clear-installation-script-set-on-release into lp:~maas-committers/maas/trunk

[Gavin Panella]

Clear a node's current_installation_script_set when releasing.

Also remove the remaining Django database fixtures. None of the tests rely upon the objects created.

An error when landing https://code.launchpad.net/~allenap/maas/only-ignore-conf-in-run/+merge/315648 led me to this fix. I was able to reproduce it locally, though not reliably. I don't understand the interaction particularly well, but this change made it impossible for me to reproduce.

This branch also eliminates the use of Django database fixtures. The landing failure from the aforementioned branch also has exceptions relating to the application of these fixtures, but none of the tests need them any more, so getting rid of them seems fairly uncontroversial.

The primary test error this branch is intended to fix:

ERROR: maasserver.models.tests.test_node.TestNode.test_release_clears_installation_results
----------------------------------------------------------------------
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Traceback (most recent call last):
  File ".../src/maastesting/runtest.py", line 134, in _run_user
    result = function(*args, **kwargs)
  File ".../testtools-2.2.0-py3.5.egg/testtools/testcase.py", line 719, in _run_test_method
    return self._get_test_method()()
  File ".../src/maasserver/models/tests/test_node.py", line 1899, in test_release_clears_installation_results
    node.release()
  File ".../src/maasserver/models/node.py", line 2394, in release
    self._release(user)
  File ".../src/maasserver/models/node.py", line 2465, in _release
    self._finalize_release()
  File ".../src/maasserver/utils/orm.py", line 669, in call_within_transaction
    return func_within_txn(*args, **kwargs)
  File "/usr/lib/python3.5/contextlib.py", line 30, in inner
    return func(*args, **kwds)
  File ".../src/maasserver/models/node.py", line 2483, in _finalize_release
    self.save()
  File ".../src/maasserver/models/node.py", line 1522, in save
    super(Node, self).save(*args, **kwargs)
  File ".../src/maasserver/models/cleansave.py", line 28, in save
    self.full_clean()
  File "/usr/lib/python3/dist-packages/django/db/models/base.py", line 1171, in full_clean
    raise ValidationError(errors)
django.core.exceptions.ValidationError: {'current_installation_script_set': ['script set instance with id 103 does not exist.']}

[Mike Pontillo (mpontillo)]

Ah, I suppose it might be recreated as a new object on save()? Weird that it wouldn't happen every time then, though...

review: Approve

=== removed directory 'src/maasserver/fixtures'
=== modified file 'src/maasserver/models/node.py'
--- src/maasserver/models/node.py	2017-01-25 15:33:49 +0000
+++ src/maasserver/models/node.py	2017-01-26 09:36:45 +0000
@@ -2453,6 +2453,7 @@
         # Clear installation results
         if self.current_installation_script_set is not None:
             self.current_installation_script_set.delete()
+            self.current_installation_script_set = None
 
         # Clear the nodes acquired filesystems.
         self._clear_acquired_filesystems()

=== removed directory 'src/metadataserver/fixtures'
=== removed file 'src/metadataserver/fixtures/initial_data.yaml'
--- src/metadataserver/fixtures/initial_data.yaml	2012-02-22 15:51:15 +0000
+++ src/metadataserver/fixtures/initial_data.yaml	1970-01-01 00:00:00 +0000
@@ -1,13 +0,0 @@
-- model: auth.user
-  pk: 1
-  fields:
-    username: 'maas-init-node'
-    first_name: 'Node initializer'
-    last_name: 'Special user'
-    email: ''
-    password: '!'
-    is_staff: false
-    is_active: false
-    is_superuser: false
-    last_login: 2012-02-16
-    date_joined: 2012-02-16