Merge lp:~allenap/maas/chassis-delete-and-create-trigger into lp:~maas-committers/maas/trunk

[Gavin Panella]

In the node_type_change_notify trigger, explicitly do nothing when a node is converted to or from a chassis.

There are some related drive-by fixes and simplifications too.

Most of this branch is drive-by changes. However...

The interesting bit is in src/maasserver/triggers/websocket.py where I've changed the node_type_change_notify trigger function to do nothing when the node is or was a chassis. This was causing test failures in TestCreateChassisHints in another branch (lp:~allenap/maas/non-django-database-test) where the CASE statement was hitting END CASE without branching; this is an error in PL/pgSQL. I haven't figured out why this failure is only observed when using that branch's new database set-up mechanism.

Nevertheless, this is an omission. I originally added a PERFORM pg_notify(...) here, but this opened other cans of worms. Most notably I tried adding a couple of scenarios — device_to_chassis and chassis_to_device — to TestNodeTypeChange but the former failed with a time-out. It turns out that nothing is sending a chassis_update message. I attempt to add that in register_websocket_triggers and realised (a) there's overlap between the triggers that are created near the start of that function (which send out, for example, machine_create and machine_delete) and the node_type_change_notify trigger function I mentioned earlier (which also sends machine_create and machine_delete).

Comments in the code are sparse. What tests there are do not give me answers. I had no idea if I should continue along this path, so I chose the least can-of-worms option I could, which is to explicitly do nothing in node_type_change_notify.

[Blake Rouse (blake-rouse)]

This is actual fine since a machine or any other node type will not be converted to a chassis. Chassis are always created explicitly.

Thanks for the cleanup of the ChassisHints!

review: Approve

[Gavin Panella (allenap)]

Thanks Blake.

Should I be concerned about the overlap between node_type_change_notify
and those at the top of register_websocket_triggers?

  @transactional
  def register_websocket_triggers():
      """Register all websocket triggers into the database."""

      for (proc_name_prefix, event_name_prefix, node_type) in (
          ('machine', 'machine', NODE_TYPE.MACHINE),
          ('rack_controller', 'controller', NODE_TYPE.RACK_CONTROLLER),
          ('region_controller', 'controller', NODE_TYPE.REGION_CONTROLLER),
          ('region_and_rack_controller', 'controller',
           NODE_TYPE.REGION_AND_RACK_CONTROLLER)):

          # Non-Device Node types
          register_procedure(
              render_notification_procedure(
                  '%s_create_notify' % proc_name_prefix,
-->               '%s_create' % event_name_prefix,
                  'NEW.system_id'))
          register_procedure(
              render_notification_procedure(
                  '%s_update_notify' % proc_name_prefix,
                  '%s_update' % event_name_prefix,
                  'NEW.system_id'))
          register_procedure(
              render_notification_procedure(
                  '%s_delete_notify' % proc_name_prefix,
-->               '%s_delete' % event_name_prefix,
                  'OLD.system_id'))
          register_trigger(
              "maasserver_node",
              "%s_create_notify" % proc_name_prefix,
              "insert",
              {'NEW.node_type': node_type})
          register_trigger(
              "maasserver_node",
              "%s_update_notify" % proc_name_prefix,
              "update",
              {'NEW.node_type': node_type})
          register_trigger(
              "maasserver_node",
              "%s_delete_notify" % proc_name_prefix,
              "delete",
              {'OLD.node_type': node_type})
      ...

Either or both the database and the listener will deduplicate these, but
it still looks like duplicated work. If that's by design we should leave
some comments behind so that my forgetful mind doesn't come back to this
like a goldfish circling the tank.

[Gavin Panella (allenap)]

I'll land this now, but the question of overlap still stands.

[Blake Rouse (blake-rouse)]

I am confused? Can you explain this a little more?

Do the procedures overlap in name?

[MAAS Lander (maas-lander)]

The attempt to merge lp:~allenap/maas/chassis-delete-and-create-trigger into lp:maas failed. Below is the output from the failed tests.

Hit:1 http://prodstack-zone-2.clouds.archive.ubuntu.com/ubuntu xenial InRelease
Get:2 http://prodstack-zone-2.clouds.archive.ubuntu.com/ubuntu xenial-updates InRelease [102 kB]
Get:3 http://prodstack-zone-2.clouds.archive.ubuntu.com/ubuntu xenial-backports InRelease [102 kB]
Get:4 http://security.ubuntu.com/ubuntu xenial-security InRelease [102 kB]
Fetched 306 kB in 0s (624 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
    --no-install-recommends install apache2 archdetect-deb authbind avahi-utils bash bind9 bind9utils build-essential bzr bzr-builddeb chromium-browser chromium-chromedriver curl daemontools debhelper dh-apport dh-systemd distro-info dnsutils firefox freeipmi-tools git gjs ipython isc-dhcp-common isc-dhcp-server libjs-angularjs libjs-jquery libjs-jquery-hotkeys libjs-yui3-full libjs-yui3-min libnss-wrapper libpq-dev make nodejs-legacy npm postgresql pxelinux python3-all python3-apt python3-attr python3-bson python3-convoy python3-crochet python3-cssselect python3-curtin python3-dev python3-distro-info python3-django python3-django-nose python3-django-piston3 python3-dnspython python3-docutils python3-formencode python3-hivex python3-httplib2 python3-jinja2 python3-jsonschema python3-lxml python3-netaddr python3-netifaces python3-novaclient python3-oauth python3-oauthlib python3-openssl python3-paramiko python3-petname python3-pexpect python3-psycopg2 python3-pyinotify python3-pyparsing python3-pyvmomi python3-requests python3-seamicroclient python3-setuptools python3-simplestreams python3-sphinx python3-tempita python3-twisted python3-txtftp python3-tz python3-yaml python3-zope.interface python-bson python-crochet python-django python-django-piston python-djorm-ext-pgarray python-formencode python-lxml python-netaddr python-netifaces python-pocket-lint python-psycopg2 python-simplejson python-tempita python-twisted python-yaml socat syslinux-common tgt ubuntu-cloudimage-keyring wget xvfb
Reading package lists...
Building dependency tree...
Reading state information...
authbind is already the newest version (2.1.1+nmu1).
avahi-utils is already the newest version (0.6.32~rc+dfsg-1ubuntu2).
build-essential is already the newest version (12.1ubuntu2).
debhelper is already the newest version (9.20160115ubuntu3).
distro-info is already the newest version (0.14build1).
git is already the newest version (1:2.7.4-0ubuntu1).
libjs-angularjs is already the newest version (1.2.28-1ubuntu2).
libjs-jquery is already the newest version (1.11.3+dfsg-4).
libjs-yui3-full is already the newest version (3.5.1-1ubuntu3).
libjs-yui3-min is already the newest version (3.5.1-1ubuntu3).
make is already the newest version (4.1-6).
postgresql is already the newest version (9.5+173).
pxelinux is already the newest version (3:6.03+dfsg-11ubuntu1).
python-formencode is already the newest version (1.3.0-0ubuntu5).
python-lxml is already the newest version (3.5.0-1build1).
python-netaddr is already the newest version (0.7.18-1).
python-netifaces is already the newest version (0.10.4-0.1build...

[Gavin Panella (allenap)]

This branch was based on a pre-non-Django-tests branch and the trigger
tests were based on some outdated assumptions. I've reformulated those.

[Gavin Panella (allenap)]

Blake wrote:
> I am confused? Can you explain this a little more?
>
> Do the procedures overlap in name?

There are many triggers on maasserver_node, but the following will
illustrate the overlap:

First is the trigger that calls node_type_change_notify when there's any
update:

  node_node_type_change_notify
    AFTER UPDATE ON maasserver_node
      FOR EACH ROW
      EXECUTE PROCEDURE node_type_change_notify()

The node_type_change_notify procedure can issue NOTIFYs with the
following pattern:

  {machine,device,controller}_{delete,create}

The other interesting triggers on maasserver_node are:

  node_device_update_notify
    AFTER UPDATE ON maasserver_node
      FOR EACH ROW WHEN (new.node_type = 1)
      EXECUTE PROCEDURE device_update_notify()

  node_machine_update_notify
    AFTER UPDATE ON maasserver_node
      FOR EACH ROW WHEN (new.node_type = 0)
      EXECUTE PROCEDURE machine_update_notify()

  node_rack_controller_update_notify
    AFTER UPDATE ON maasserver_node
      FOR EACH ROW WHEN (new.node_type = 2)
      EXECUTE PROCEDURE rack_controller_update_notify()

  node_region_and_rack_controller_update_notify
    AFTER UPDATE ON maasserver_node
      FOR EACH ROW WHEN (new.node_type = 4)
      EXECUTE PROCEDURE region_and_rack_controller_update_notify()

  node_region_controller_update_notify
    AFTER UPDATE ON maasserver_node
      FOR EACH ROW WHEN (new.node_type = 3)
      EXECUTE PROCEDURE region_controller_update_notify()

Take machine_update_notify as an example:

  DECLARE
  BEGIN
    PERFORM pg_notify('machine_update',CAST(NEW.system_id AS text));
    RETURN NEW;
  END;

So, when a node is converted from, say, a rack controller to a machine,
the following messages will be NOTIFY'ed:

  machine_update (via node_machine_update_notify)
  controller_delete (via node_node_type_change_notify)
  machine_create (via node_node_type_change_notify)

This is a confusing order for things to appear in: the update before the
create.

FWIW, the order is stable: PostgreSQL says that NOTIFY'ed messages are
delivered in order [1] and triggers are run in alphabetical order [2].

Converting back from a machine to a rack controller will, I think,
result in:

  machine_delete (via node_node_type_change_notify)
  controller_create (via node_node_type_change_notify)
  controller_update (via node_rack_controller_update_notify)

This is a more sensible order, but it also differs from before. The
presence of both *_create and *_update messages in both examples is also
repetition: both messages arise from the same event, an update.

Now, I don't know of anything that depends on this ordering, but I also
don't know all of the code. A few things stand out:

- We may already have bugs related to this ordering.

- We may create bugs related to this ordering in future.

- It's hard to figure all of MAAS's trigger stuff out.

I don't have an answer to this, but I do think that the way we compose
procedures and triggers has been outgrown by the complexity of the
systems that are reliant upon it. There are still manual steps required
to join up all the pieces. I'd like to be able to say it declaritively,
like:

  When a row in table foo is u...

=== modified file 'src/maasserver/models/signals/nodes.py'
--- src/maasserver/models/signals/nodes.py	2017-01-03 19:37:46 +0000
+++ src/maasserver/models/signals/nodes.py	2017-01-10 13:35:41 +0000
@@ -115,15 +115,10 @@
 
 def create_chassis_hints(sender, instance, created, **kwargs):
     """Create `ChassisHints` when `Chassis` is created."""
-    try:
-        chassis_hints = instance.chassis_hints
-    except ChassisHints.DoesNotExist:
-        chassis_hints = None
     if instance.node_type == NODE_TYPE.CHASSIS:
-        if chassis_hints is None:
-            ChassisHints.objects.create(chassis=instance)
-    elif chassis_hints is not None:
-        chassis_hints.delete()
+        ChassisHints.objects.get_or_create(chassis=instance)
+    else:
+        ChassisHints.objects.filter(chassis=instance).delete()
 
 for klass in NODE_CLASSES:
     signals.watch(

=== modified file 'src/maasserver/models/signals/tests/test_nodes.py'
--- src/maasserver/models/signals/tests/test_nodes.py	2017-01-05 15:21:29 +0000
+++ src/maasserver/models/signals/tests/test_nodes.py	2017-01-10 13:35:41 +0000
@@ -163,9 +163,6 @@
         chassis = factory.make_Node(node_type=NODE_TYPE.CHASSIS)
         chassis.node_type = NODE_TYPE.DEVICE
         chassis.save()
-        error = None
-        try:
-            reload_object(chassis).chassis_hints
-        except ChassisHints.DoesNotExist as exc:
-            error = exc
-        self.assertIsNotNone(error)
+        self.assertRaises(
+            ChassisHints.DoesNotExist,
+            lambda: chassis.chassis_hints)

=== modified file 'src/maasserver/triggers/tests/test_init.py'
--- src/maasserver/triggers/tests/test_init.py	2016-03-28 13:54:47 +0000
+++ src/maasserver/triggers/tests/test_init.py	2017-01-10 13:35:41 +0000
@@ -13,7 +13,15 @@
     register_procedure,
     register_trigger,
 )
-from maasserver.triggers.websocket import render_notification_procedure
+from maasserver.triggers.system import register_system_triggers
+from maasserver.triggers.websocket import (
+    register_websocket_triggers,
+    render_notification_procedure,
+)
+from testtools.matchers import Equals
+
+
+EMPTY_SET = frozenset()
 
 
 class TestTriggers(MAASServerTestCase):
@@ -46,3 +54,214 @@
             triggers = cursor.fetchall()
 
         self.assertEqual(1, len(triggers), "Trigger was not created.")
+
+
+class TestTriggersUsed(MAASServerTestCase):
+    """Tests relating to those triggers the MAAS application uses."""
+
+    triggers_system = {
+        "config_sys_dhcp_config_ntp_servers_delete",
+        "config_sys_dhcp_config_ntp_servers_insert",
+        "config_sys_dhcp_config_ntp_servers_update",
+        "config_sys_dns_config_insert",
+        "config_sys_dns_config_update",
+        "dhcpsnippet_sys_dhcp_snippet_delete",
+        "dhcpsnippet_sys_dhcp_snippet_insert",
+        "dhcpsnippet_sys_dhcp_snippet_update",
+        "dnsdata_sys_dns_dnsdata_delete",
+        "dnsdata_sys_dns_dnsdata_insert",
+        "dnsdata_sys_dns_dnsdata_update",
+        "dnspublication_sys_dns_publish",
+        "dnsresource_ip_addresses_sys_dns_dnsresource_ip_link",
+        "dnsresource_ip_addresses_sys_dns_dnsresource_ip_unlink",
+        "dnsresource_sys_dns_dnsresource_delete",
+        "dnsresource_sys_dns_dnsresource_insert",
+        "dnsresource_sys_dns_dnsresource_update",
+        "domain_sys_dns_domain_delete",
+        "domain_sys_dns_domain_insert",
+        "domain_sys_dns_domain_update",
+        "interface_ip_addresses_sys_dns_nic_ip_link",
+        "interface_ip_addresses_sys_dns_nic_ip_unlink",
+        "interface_sys_dhcp_interface_update",
+        "interface_sys_dns_interface_update",
+        "iprange_sys_dhcp_iprange_delete",
+        "iprange_sys_dhcp_iprange_insert",
+        "iprange_sys_dhcp_iprange_update",
+        "node_sys_dhcp_node_update",
+        "node_sys_dns_node_delete",
+        "node_sys_dns_node_update",
+        "regionrackrpcconnection_sys_core_rpc_delete",
+        "regionrackrpcconnection_sys_core_rpc_insert",
+        "staticipaddress_sys_dhcp_staticipaddress_delete",
+        "staticipaddress_sys_dhcp_staticipaddress_insert",
+        "staticipaddress_sys_dhcp_staticipaddress_update",
+        "staticipaddress_sys_dns_staticipaddress_update",
+        "subnet_sys_dhcp_subnet_delete",
+        "subnet_sys_dhcp_subnet_update",
+        "subnet_sys_dns_subnet_delete",
+        "subnet_sys_dns_subnet_insert",
+        "subnet_sys_dns_subnet_update",
+        "subnet_sys_proxy_subnet_delete",
+        "subnet_sys_proxy_subnet_insert",
+        "subnet_sys_proxy_subnet_update",
+        "vlan_sys_dhcp_vlan_update",
+    }
+
+    triggers_websocket = {
+        "auth_user_user_create_notify",
+        "auth_user_user_delete_notify",
+        "auth_user_user_update_notify",
+        "blockdevice_nd_blockdevice_link_notify",
+        "blockdevice_nd_blockdevice_unlink_notify",
+        "blockdevice_nd_blockdevice_update_notify",
+        "cacheset_nd_cacheset_link_notify",
+        "cacheset_nd_cacheset_unlink_notify",
+        "cacheset_nd_cacheset_update_notify",
+        "config_config_create_notify",
+        "config_config_delete_notify",
+        "config_config_update_notify",
+        "dhcpsnippet_dhcpsnippet_create_notify",
+        "dhcpsnippet_dhcpsnippet_delete_notify",
+        "dhcpsnippet_dhcpsnippet_update_notify",
+        "dnsdata_dnsdata_domain_delete_notify",
+        "dnsdata_dnsdata_domain_insert_notify",
+        "dnsdata_dnsdata_domain_update_notify",
+        "dnsresource_dnsresource_domain_delete_notify",
+        "dnsresource_dnsresource_domain_insert_notify",
+        "dnsresource_dnsresource_domain_update_notify",
+        "dnsresource_ip_addresses_rrset_sipaddress_link_notify",
+        "dnsresource_ip_addresses_rrset_sipaddress_unlink_notify",
+        "domain_domain_create_notify",
+        "domain_domain_delete_notify",
+        "domain_domain_node_update_notify",
+        "domain_domain_update_notify",
+        "event_event_create_machine_device_notify",
+        "event_event_create_notify",
+        "fabric_fabric_create_notify",
+        "fabric_fabric_delete_notify",
+        "fabric_fabric_machine_update_notify",
+        "fabric_fabric_update_notify",
+        "filesystem_nd_filesystem_link_notify",
+        "filesystem_nd_filesystem_unlink_notify",
+        "filesystem_nd_filesystem_update_notify",
+        "filesystemgroup_nd_filesystemgroup_link_notify",
+        "filesystemgroup_nd_filesystemgroup_unlink_notify",
+        "filesystemgroup_nd_filesystemgroup_update_notify",
+        "interface_ip_addresses_nd_sipaddress_dns_link_notify",
+        "interface_ip_addresses_nd_sipaddress_dns_unlink_notify",
+        "interface_ip_addresses_nd_sipaddress_link_notify",
+        "interface_ip_addresses_nd_sipaddress_unlink_notify",
+        "interface_nd_interface_link_notify",
+        "interface_nd_interface_unlink_notify",
+        "interface_nd_interface_update_notify",
+        "iprange_iprange_create_notify",
+        "iprange_iprange_delete_notify",
+        "iprange_iprange_subnet_delete_notify",
+        "iprange_iprange_subnet_insert_notify",
+        "iprange_iprange_subnet_update_notify",
+        "iprange_iprange_update_notify",
+        "metadataserver_noderesult_nd_noderesult_link_notify",
+        "metadataserver_noderesult_nd_noderesult_unlink_notify",
+        "neighbour_neighbour_create_notify",
+        "neighbour_neighbour_delete_notify",
+        "neighbour_neighbour_update_notify",
+        "node_device_create_notify",
+        "node_device_delete_notify",
+        "node_device_update_notify",
+        "node_machine_create_notify",
+        "node_machine_delete_notify",
+        "node_machine_update_notify",
+        "node_node_type_change_notify",
+        "node_rack_controller_create_notify",
+        "node_rack_controller_delete_notify",
+        "node_rack_controller_update_notify",
+        "node_region_and_rack_controller_create_notify",
+        "node_region_and_rack_controller_delete_notify",
+        "node_region_and_rack_controller_update_notify",
+        "node_region_controller_create_notify",
+        "node_region_controller_delete_notify",
+        "node_region_controller_update_notify",
+        "node_tags_machine_device_tag_link_notify",
+        "node_tags_machine_device_tag_unlink_notify",
+        "packagerepository_packagerepository_create_notify",
+        "packagerepository_packagerepository_delete_notify",
+        "packagerepository_packagerepository_update_notify",
+        "partition_nd_partition_link_notify",
+        "partition_nd_partition_unlink_notify",
+        "partition_nd_partition_update_notify",
+        "partitiontable_nd_partitiontable_link_notify",
+        "partitiontable_nd_partitiontable_unlink_notify",
+        "partitiontable_nd_partitiontable_update_notify",
+        "physicalblockdevice_nd_physblockdevice_update_notify",
+        "service_service_create_notify",
+        "service_service_delete_notify",
+        "service_service_update_notify",
+        "space_space_create_notify",
+        "space_space_delete_notify",
+        "space_space_machine_update_notify",
+        "space_space_update_notify",
+        "sshkey_sshkey_create_notify",
+        "sshkey_sshkey_delete_notify",
+        "sshkey_sshkey_update_notify",
+        "sshkey_user_sshkey_link_notify",
+        "sshkey_user_sshkey_unlink_notify",
+        "sslkey_user_sslkey_link_notify",
+        "sslkey_user_sslkey_unlink_notify",
+        "staticipaddress_ipaddress_domain_delete_notify",
+        "staticipaddress_ipaddress_domain_insert_notify",
+        "staticipaddress_ipaddress_domain_update_notify",
+        "staticipaddress_ipaddress_machine_update_notify",
+        "staticipaddress_ipaddress_subnet_update_notify",
+        "staticroute_staticroute_create_notify",
+        "staticroute_staticroute_delete_notify",
+        "staticroute_staticroute_update_notify",
+        "subnet_subnet_create_notify",
+        "subnet_subnet_delete_notify",
+        "subnet_subnet_machine_update_notify",
+        "subnet_subnet_update_notify",
+        "tag_tag_create_notify",
+        "tag_tag_delete_notify",
+        "tag_tag_update_machine_device_notify",
+        "tag_tag_update_notify",
+        "virtualblockdevice_nd_virtblockdevice_update_notify",
+        "vlan_vlan_create_notify",
+        "vlan_vlan_delete_notify",
+        "vlan_vlan_machine_update_notify",
+        "vlan_vlan_update_notify",
+        "zone_zone_create_notify",
+        "zone_zone_delete_notify",
+        "zone_zone_update_notify",
+    }
+
+    triggers_all = triggers_system | triggers_websocket
+
+    def find_triggers_in_database(self):
+        with connection.cursor() as cursor:
+            cursor.execute(
+                "SELECT tgname::text FROM pg_trigger "
+                "WHERE NOT tgisinternal")
+            return {tgname for tgname, in cursor.fetchall()}
+
+    def check_triggers_in_database(self):
+        # Note: if this test fails, a trigger may have been added, but not
+        # added to the list of expected triggers.
+        triggers_found = self.find_triggers_in_database()
+        self.expectThat(
+            (self.triggers_all - triggers_found), Equals(EMPTY_SET),
+            "Some triggers were expected but not found.")
+        self.expectThat(
+            (triggers_found - self.triggers_all), Equals(EMPTY_SET),
+            "Some triggers were unexpected.")
+
+    def test_all_triggers_present_and_correct(self):
+        # Running in a fully migrated database means all triggers should be
+        # present from the get go.
+        self.check_triggers_in_database()
+
+    def test_register_system_triggers_does_not_introduce_more(self):
+        register_system_triggers()
+        self.check_triggers_in_database()
+
+    def test_register_websocket_triggers_does_not_introduce_more(self):
+        register_websocket_triggers()
+        self.check_triggers_in_database()

=== removed file 'src/maasserver/triggers/tests/test_websocket.py'
--- src/maasserver/triggers/tests/test_websocket.py	2016-10-20 20:56:24 +0000
+++ src/maasserver/triggers/tests/test_websocket.py	1970-01-01 00:00:00 +0000
@@ -1,127 +0,0 @@
-# Copyright 2015-2016 Canonical Ltd.  This software is licensed under the
-# GNU Affero General Public License version 3 (see the file LICENSE).
-
-"""Tests for `maasserver.triggers.websocket`."""
-
-__all__ = []
-
-from contextlib import closing
-
-from django.db import connection
-from maasserver.testing.testcase import MAASServerTestCase
-from maasserver.triggers.websocket import register_websocket_triggers
-from maasserver.utils.orm import psql_array
-
-
-class TestTriggers(MAASServerTestCase):
-
-    def test_register_websocket_triggers(self):
-        register_websocket_triggers()
-        triggers = [
-            "node_machine_create_notify",
-            "node_machine_update_notify",
-            "node_machine_delete_notify",
-            "node_device_create_notify",
-            "node_device_update_notify",
-            "node_device_delete_notify",
-            "config_config_create_notify",
-            "config_config_update_notify",
-            "config_config_delete_notify",
-            "node_rack_controller_create_notify",
-            "node_rack_controller_update_notify",
-            "node_rack_controller_delete_notify",
-            "node_region_controller_create_notify",
-            "node_region_controller_update_notify",
-            "node_region_controller_delete_notify",
-            "node_region_and_rack_controller_create_notify",
-            "node_region_and_rack_controller_update_notify",
-            "node_region_and_rack_controller_delete_notify",
-            "zone_zone_create_notify",
-            "zone_zone_update_notify",
-            "zone_zone_delete_notify",
-            "tag_tag_create_notify",
-            "tag_tag_update_notify",
-            "tag_tag_delete_notify",
-            "node_tags_machine_device_tag_link_notify",
-            "node_tags_machine_device_tag_unlink_notify",
-            "tag_tag_update_machine_device_notify",
-            "auth_user_user_create_notify",
-            "auth_user_user_update_notify",
-            "auth_user_user_delete_notify",
-            "event_event_create_notify",
-            "event_event_create_machine_device_notify",
-            "interface_ip_addresses_nd_sipaddress_link_notify",
-            "interface_ip_addresses_nd_sipaddress_unlink_notify",
-            "interface_ip_addresses_nd_sipaddress_dns_link_notify",
-            "interface_ip_addresses_nd_sipaddress_dns_unlink_notify",
-            "dnsresource_ip_addresses_rrset_sipaddress_link_notify",
-            "dnsresource_ip_addresses_rrset_sipaddress_unlink_notify",
-            "metadataserver_noderesult_nd_noderesult_link_notify",
-            "metadataserver_noderesult_nd_noderesult_unlink_notify",
-            "interface_nd_interface_link_notify",
-            "interface_nd_interface_unlink_notify",
-            "interface_nd_interface_update_notify",
-            "blockdevice_nd_blockdevice_link_notify",
-            "blockdevice_nd_blockdevice_unlink_notify",
-            "physicalblockdevice_nd_physblockdevice_update_notify",
-            "virtualblockdevice_nd_virtblockdevice_update_notify",
-            "sshkey_user_sshkey_link_notify",
-            "sshkey_user_sshkey_unlink_notify",
-            "sshkey_sshkey_create_notify",
-            "sshkey_sshkey_update_notify",
-            "sshkey_sshkey_delete_notify",
-            "sslkey_user_sslkey_link_notify",
-            "sslkey_user_sslkey_unlink_notify",
-            "fabric_fabric_create_notify",
-            "fabric_fabric_update_notify",
-            "fabric_fabric_delete_notify",
-            "vlan_vlan_create_notify",
-            "vlan_vlan_update_notify",
-            "vlan_vlan_delete_notify",
-            "neighbour_neighbour_create_notify",
-            "neighbour_neighbour_update_notify",
-            "neighbour_neighbour_delete_notify",
-            "iprange_iprange_create_notify",
-            "iprange_iprange_update_notify",
-            "iprange_iprange_delete_notify",
-            "staticroute_staticroute_create_notify",
-            "staticroute_staticroute_update_notify",
-            "staticroute_staticroute_delete_notify",
-            "subnet_subnet_create_notify",
-            "subnet_subnet_update_notify",
-            "subnet_subnet_delete_notify",
-            "space_space_create_notify",
-            "space_space_update_notify",
-            "space_space_delete_notify",
-            "subnet_subnet_machine_update_notify",
-            "fabric_fabric_machine_update_notify",
-            "space_space_machine_update_notify",
-            "vlan_vlan_machine_update_notify",
-            "staticipaddress_ipaddress_machine_update_notify",
-            "staticipaddress_ipaddress_subnet_update_notify",
-            "dhcpsnippet_dhcpsnippet_create_notify",
-            "dhcpsnippet_dhcpsnippet_update_notify",
-            "dhcpsnippet_dhcpsnippet_delete_notify",
-            "iprange_iprange_subnet_insert_notify",
-            "iprange_iprange_subnet_update_notify",
-            "iprange_iprange_subnet_delete_notify",
-            ]
-        sql, args = psql_array(triggers, sql_type="text")
-        with closing(connection.cursor()) as cursor:
-            cursor.execute(
-                "SELECT tgname::text FROM pg_trigger WHERE "
-                "tgname::text = ANY(%s) " % sql, args)
-            db_triggers = cursor.fetchall()
-
-        # Note: if this test fails, a trigger may have been added, but not
-        # added to the list of expected triggers.
-        triggers_found = [trigger[0] for trigger in db_triggers]
-        self.assertEqual(
-            len(triggers), len(db_triggers),
-            "Missing %s triggers in the database. Triggers found: %s" % (
-                len(triggers) - len(db_triggers), triggers_found))
-
-        self.assertItemsEqual(
-            triggers, triggers_found,
-            "Missing triggers in the database. Triggers found: %s" % (
-                triggers_found))