Merge lp:~allenap/launchpad/show-me-too-spinner into lp:launchpad

[Gavin Panella]

Make the 'Does this bug affect you?' spinner always appear, and appear in the right place, and fix the mouse cursor when hovering over the edit icon. Previously the spinner would only appear if the flame icon had been visible, the spinner would replace the flame icon instead of the edit icon, and the mouse cursor did not change when hovering over the edit icon.

[Gavin Panella (allenap)]

Change the HTML_PARSER declaration in MeTooChoiceSource to use the editicon CSS class instead of src$=/@@/edit. The src$=... rule seemed to be either not finding the correct image, or not finding any image.

[Deryck Hodge (deryck)]

Looks good to me. Thanks for making this change!

As I mentioned on IRC, it would be nice to fix bug 415161 at the same time as this change. But I leave that your judgment.

Cheers,
deryck

review: Approve (code js)

[Данило Шеган (danilo)]

Looks good.

review: Approve (release-critical)

[Deryck Hodge (deryck)]

Gavin,

The addition for the correct icon cursor looks good. Thanks!

However, there needs to be a CSS rule to prevent the icon being underlined on hover now.

Cheers,
deryck

[Gavin Panella (allenap)]

Hi Deryck. I've fixed the underline issue by putting the edit icon in its own <a>...</a>, so that the js-action class is not applied to it. Seems to work nicely.

=== modified file 'lib/canonical/launchpad/javascript/bugs/bugtask-index.js'
--- lib/canonical/launchpad/javascript/bugs/bugtask-index.js	2009-12-10 20:59:49 +0000
+++ lib/canonical/launchpad/javascript/bugs/bugtask-index.js	2009-12-14 20:59:13 +0000
@@ -1504,7 +1504,7 @@
     var me_too_edit = new MeTooChoiceSource({
         contentBox: me_too_content, value: user_is_affected,
         elementToFlash: me_too_content,
-        editicon: ".dynamic img[src$=/@@/edit]",
+        editicon: ".dynamic img.editicon",
         others_affected_count: others_affected_count
     });
     me_too_edit.render();

=== modified file 'lib/lp/bugs/templates/bugtasks-and-nominations-table.pt'
--- lib/lp/bugs/templates/bugtasks-and-nominations-table.pt	2009-12-11 14:00:13 +0000
+++ lib/lp/bugs/templates/bugtasks-and-nominations-table.pt	2009-12-14 20:59:13 +0000
@@ -34,7 +34,9 @@
           <img src="/@@/flame-icon" alt=""/>
           <a href="+affectsmetoo" class="js-action"
              ><span class="value" tal:content="view/affected_statement" /></a>
-          <img class="editicon" src="/@@/edit" alt="Edit" />
+          <a href="+affectsmetoo">
+            <img class="editicon" src="/@@/edit" alt="Edit" />
+          </a>
         </span>
         <script type="text/javascript" tal:content="string:
           LPS.use('event', 'bugs.bugtask_index', function(Y) {