Merge lp:~allenap/launchpad/patch-report-for-people-and-teams-bug-506018 into lp:launchpad

[Gavin Panella]

[Gavin Panella (allenap)]

IPerson does not inherit from IHasBugs, so I've registered the BugPatchesView for IPerson too, and added a simple test to show it works.

[Eleanor Berger (intellectronica)]

nicely done!

review: Approve (code)

[Gavin Panella (allenap)]

Please see r10187, some changes that Abel suggested I add to this branch.

=== modified file 'lib/lp/bugs/browser/bugtarget.py'
--- lib/lp/bugs/browser/bugtarget.py	2010-02-03 17:54:20 +0000
+++ lib/lp/bugs/browser/bugtarget.py	2010-02-03 17:54:22 +0000
@@ -70,6 +70,7 @@
 from lp.registry.interfaces.distributionsourcepackage import (
     IDistributionSourcePackage)
 from lp.registry.interfaces.distroseries import IDistroSeries
+from lp.registry.interfaces.person import IPerson
 from lp.registry.interfaces.product import IProduct
 from lp.registry.interfaces.productseries import IProductSeries
 from lp.registry.interfaces.project import IProject
@@ -1398,7 +1399,10 @@
     @property
     def label(self):
         """The display label for the view."""
-        return 'Patch attachments in %s' % self.context.displayname
+        if IPerson.providedBy(self.context):
+            return 'Patch attachments for %s' % self.context.displayname
+        else:
+            return 'Patch attachments in %s' % self.context.displayname
 
     def batchedPatchTasks(self):
         """Return a BatchNavigator for bug tasks with patch attachments."""
@@ -1418,12 +1422,13 @@
                 status=UNRESOLVED_PLUS_FIXRELEASED_BUGTASK_STATUSES,
                 omit_duplicates=True, has_patch=True),
             self.request)
-        
+
     def shouldShowTargetName(self):
         """Return True if current context can have different bugtargets."""
         return (IDistribution.providedBy(self.context) or
                 IDistroSeries.providedBy(self.context) or
-                IProject.providedBy(self.context))
+                IProject.providedBy(self.context) or
+                IPerson.providedBy(self.context))
 
     def youngestPatch(self, bug):
         """Return the youngest patch attached to a bug, else error."""

=== modified file 'lib/lp/bugs/browser/configure.zcml'
--- lib/lp/bugs/browser/configure.zcml	2010-02-03 17:54:20 +0000
+++ lib/lp/bugs/browser/configure.zcml	2010-02-03 17:54:23 +0000
@@ -115,6 +115,13 @@
             facet="bugs"
             permission="zope.Public"
             template="../templates/bugtarget-patches.pt"/>
+        <browser:page
+            name="+patches"
+            for="lp.registry.interfaces.person.IPerson"
+            class="lp.bugs.browser.bugtarget.BugsPatchesView"
+            facet="bugs"
+            permission="zope.Public"
+            template="../templates/bugtarget-patches.pt"/>
     </facet>
     <browser:page
         name="+bugtarget-macros-search"

=== modified file 'lib/lp/bugs/stories/patches-view/patches-view.txt'
--- lib/lp/bugs/stories/patches-view/patches-view.txt	2010-02-03 17:54:20 +0000
+++ lib/lp/bugs/stories/patches-view/patches-view.txt	2010-02-03 17:54:23 +0000
@@ -9,7 +9,7 @@
 
     >>> patchy_product = factory.doAsUser(
     ...     '[e-mail]', factory.makeProduct,
-    ...     name='patchy-product-1')
+    ...     name='patchy-product-1', displayname="Patchy 1")
 
 We don't see any patches when we open the patches view.
 
@@ -76,6 +76,13 @@
     From: Patchy Person
     Link: patch_a.diff description of patch a
 
+The page title and other wording in the page reflects the contents.
+
+    >>> print_location(user_browser.contents)
+    Hierarchy: Patchy 1 > Bugs > Patch attachments in Patchy 1
+    Tabs: ...
+    Main heading: Patch attachments in Patchy 1
+
 After creating some more bugs, with some non-patch and some patch
 attachments...
 
@@ -218,7 +225,7 @@
     ...     '[e-mail]', make_bugtask,
     ...     bug=bug_c, target=patchy_product_series)
     >>> user_browser.open(
-    ...     'https://launchpad.dev/patchy-product-1/trunk/+patches')
+    ...     'https://bugs.launchpad.dev/patchy-product-1/trunk/+patches')
     >>> show_patches_view(user_browser.contents)
     Bug                       Importance     Status      Patch Age
     Bug #18: bug_c title       Wishlist  Fix Committed   ...second...
@@ -230,6 +237,13 @@
     Link: patch_a.diff
     description of patch a
 
+The page title and other wording in the page reflects the contents.
+
+    >>> print_location(user_browser.contents)
+    Hierarchy: Patchy 1 > Series trunk > Bugs > Patch attachments in trunk
+    Tabs: ...
+    Main heading: Patch attachments in trunk
+
 Patches View by Distro
 ----------------------
 
@@ -248,6 +262,7 @@
     ...     status=BugTaskStatus.TRIAGED)
 
     >>> user_browser.open('http://bugs.launchpad.dev/ubuntu/+patches')
+
     >>> show_patches_view(user_browser.contents)
     Bug                       Importance   Status    Package    Patch Age
     Bug #18: bug_c title       High       Triaged    a52dec  ...second...
@@ -257,6 +272,11 @@
     From: Patchy Person
     Link: patch_a.diff description of patch a
 
+    >>> print_location(user_browser.contents)
+    Hierarchy: Ubuntu > Bugs > Patch attachments in Ubuntu
+    Tabs: ...
+    Main heading: Patch attachments in Ubuntu
+
 Patches View by Distro Series
 -----------------------------
 
@@ -276,14 +296,16 @@
     ...     target='warty', target_is_distroseries_name=True,
     ...     importance=BugTaskImportance.HIGH,
     ...     status=BugTaskStatus.TRIAGED)
-    >>> user_browser.open('https://launchpad.dev/ubuntu/hoary/+patches')
+
+    >>> user_browser.open('https://bugs.launchpad.dev/ubuntu/hoary/+patches')
     >>> show_patches_view(user_browser.contents)
     Bug                       Importance   Status   Package    Patch Age
     Bug #16: bug_a title     Undecided       New    hoary     ...second...
     From: Patchy Person
     Link: patch_a.diff
     description of patch a
-    >>> user_browser.open('https://launchpad.dev/ubuntu/warty/+patches')
+
+    >>> user_browser.open('https://bugs.launchpad.dev/ubuntu/warty/+patches')
     >>> show_patches_view(user_browser.contents)
     Bug                       Importance   Status   Package    Patch Age
     Bug #18: bug_c title        High       Triaged   warty    ...second...
@@ -298,6 +320,11 @@
     Link: patch_c.diff
     description of patch c
 
+    >>> print_location(user_browser.contents)
+    Hierarchy: Ubuntu > Warty (4.10) > Bugs > Patch attachments in Warty
+    Tabs: ...
+    Main heading: Patch attachments in Warty
+
 Patches View by Source Package
 ------------------------------
 
@@ -318,3 +345,45 @@
     Bug #16: bug_a title       Medium   Fix Released  ...second...
     From: Patchy Person
     Link: patch_a.diff description of patch a
+
+    >>> print_location(user_browser.contents)
+    Hierarchy: Ubuntu > ?evolution? package > Bugs > Patch ...
+    Tabs: ...
+    Main heading: Patch attachments in evolution in ubuntu
+
+Patches View by Person and Team
+-------------------------------
+
+The patches view works for people and teams.
+
+    >>> user_browser.open(
+    ...     'http://bugs.launchpad.dev/~%s/+patches' % (
+    ...         patch_submitter.name,))
+
+    >>> show_patches_view(user_browser.contents)
+    Bug  Importance  Status  Package  Patch Age
+    Bug #17: bug_b title  Critical  Confirmed  patchy-product-1 ...second...
+    From: Patchy Person
+    Link: patch_c.diff
+    description of patch c
+    Bug #18: bug_c title  High  Triaged  a52dec  ...second...
+    From: Patchy Person
+    Link: patch_f.diff
+    description of patch f
+    Bug #18: bug_c title  High  Triaged  warty  ...second...
+    From: Patchy Person
+    Link: patch_f.diff
+    description of patch f
+    Bug #16: bug_a title  Medium  Fix Released  evolution  ...second...
+    From: Patchy Person
+    Link: patch_a.diff
+    description of patch a
+    Bug #18: bug_c title  Wishlist  Fix Committed  patchy-product-1  ...second...
+    From: Patchy Person
+    Link: patch_f.diff
+    description of patch f
+
+    >>> print_location(user_browser.contents)
+    Hierarchy: Patchy Person > Patch attachments for Patchy Person
+    Tabs: ...
+    Main heading: Patch attachments for Patchy Person