Launchpad itself

Merge lp:~allenap/launchpad/last-changed-scrolling-bug-819226 into lp:launchpad

  1. last-changed-scrolling-bug-819226
  2. Merge into devel
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: 13575
Proposed branch: lp:~allenap/launchpad/last-changed-scrolling-bug-819226
Merge into: lp:launchpad
Diff against target: 14 lines (+0/-4)
1 file modified
lib/lp/registry/javascript/distroseries/differences.js (+0/-4)
To merge this branch: bzr merge lp:~allenap/launchpad/last-changed-scrolling-bug-819226
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+69989@code.launchpad.net

Commit message

[r=allenap][bug=819226] Stop page from scrolling weirdly when opening "Last changed" person picker on +localpackagediffs.

Description of the change

Stop the weird scrolling problem. See bug report for more info.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/javascript/distroseries/differences.js'
2--- lib/lp/registry/javascript/distroseries/differences.js 2011-07-29 15:23:27 +0000
3+++ lib/lp/registry/javascript/distroseries/differences.js 2011-08-01 12:21:59 +0000
4@@ -229,10 +229,6 @@
5 ]
6 };
7
8- /* lazr.picker.Picker sets centered to true each time the picker
9- is shown. Not happy. Killing it with fire^W preventDefault. */
10- picker.on("centeredChange", function(e) { e.preventDefault(); });
11-
12 /* XXX: GavinPanella 2011-07-27 bug=817091: Alignment must be done
13 after creating the picker because lp.app.picker.create()
14 clobbers the passed configuration. */