Merge lp:~allenap/launchpad/last-changed-remove-person-button-bug-819227 into lp:launchpad

[Gavin Panella]

[r=allenap][bug=819227] Ensure that the "Remove person" button appears when appropriate in the "Last changed" person picker on +localpackagediffs.

Update both selected_value and the search box on the picker instead of just the search box. See the XXX'ed bug (bug 819274) for more information.

[Gavin Panella (allenap)]

review: Approve

=== modified file 'lib/lp/registry/javascript/distroseries/differences.js'
--- lib/lp/registry/javascript/distroseries/differences.js	2011-08-01 12:40:21 +0000
+++ lib/lp/registry/javascript/distroseries/differences.js	2011-08-01 12:40:23 +0000
@@ -239,11 +239,19 @@
             picker.set("align", align);  // Arg.
             var changed_by = get_changed_by_in_query(window.location.search);
             if (Y.Lang.isValue(changed_by)) {
-                picker._search_input.set("value", changed_by);
+                picker.set("selected_value", changed_by);
             }
         }
     });
 
+    /* Update the search box. XXX: GavinPanella 2011-08-01 bug=819274:
+       This should probably be handled by the picker itself. There is
+       code in TextFieldPickerPlugin to do something similar, but
+       that's probably not the right place either. */
+    picker.after("selected_valueChange", function(e) {
+        picker._search_input.set("value", e.newVal);
+    });
+
     /* When the picker is saved the search filter form is modified and
        submitted. */
     picker.on("save", function(e) {