Merge lp:~allenap/launchpad/fix-iharness-bug-432665 into lp:launchpad

Proposed by Gavin Panella on 2009-09-21
Status: Merged
Approved by: Gavin Panella on 2009-09-22
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~allenap/launchpad/fix-iharness-bug-432665
Merge into: lp:launchpad
Diff against target: 19 lines
1 file modified
buildout.cfg (+4/-6)
To merge this branch: bzr merge lp:~allenap/launchpad/fix-iharness-bug-432665
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical 2009-09-22 Disapprove on 2009-09-22
Eleanor Berger (community) 2009-09-21 Approve on 2009-09-21
Review via email:
To post a comment you must log in.
Gavin Panella (allenap) wrote :

Fixes the iharness buildout target to have all the same options that the scripts target has. This means that the resulting bin/iharness script has only one line different to bin/harness.

review: Approve
Brad Crittenden (bac) wrote :


This branch is fine work and I look forward to it landing (I filed the bug afterall). It does not, however, impact operation and doesn't meet the requirements for 'release critical'. Please land this when PQM re-opens.

review: Disapprove (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'buildout.cfg'
2--- buildout.cfg 2009-08-21 19:13:05 +0000
3+++ buildout.cfg 2009-09-30 16:45:27 +0000
4@@ -70,12 +70,10 @@
6 [iharness]
7 recipe = zc.recipe.egg
8-eggs = lp
9- ipython
10-extra-paths = ${buildout:directory}/lib/mailman
11-initialization = import os
12- os.environ['STORM_CEXTENSIONS'] = '1'
13- os.environ['LPCONFIG'] = '${configuration:instance_name}'
14+eggs = ${scripts:eggs}
15+ ipython
16+extra-paths = ${scripts:extra-paths}
17+initialization = ${scripts:initialization}
18 entry-points = iharness=canonical.database.harness:ipython
19 scripts = iharness ipython=ipy