Merge lp:~allenap/launchpad/bug-mail-case-sensitive-domain-bug-48464-fix into lp:launchpad
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12057 |
Proposed branch: | lp:~allenap/launchpad/bug-mail-case-sensitive-domain-bug-48464-fix |
Merge into: | lp:launchpad |
Prerequisite: | lp:~allenap/launchpad/bug-mail-case-sensitive-domain-bug-48464-refactor |
Diff against target: |
163 lines (+65/-44) 3 files modified
lib/lp/services/mail/handlers.py (+19/-35) lib/lp/services/mail/tests/incomingmail.txt (+5/-3) lib/lp/services/mail/tests/test_handlers.py (+41/-6) |
To merge this branch: | bzr merge lp:~allenap/launchpad/bug-mail-case-sensitive-domain-bug-48464-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+43547@code.launchpad.net |
Commit message
[r=abentley]
Description of the change
This makes MailHandler case-insensitive to domains, moves its doctests into unit tests, and updates the integration test, incomingmail.txt, to demonstrate case-insensitivity.
To post a comment you must log in.
The code looks good.
Please add docs for all the tests. The copyright date for test_handlers should be 2009-2010, not just 2010.