Merge lp:~allenap/gwacl/tests-not-testing into lp:gwacl
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | 223 |
Merged at revision: | 222 |
Proposed branch: | lp:~allenap/gwacl/tests-not-testing |
Merge into: | lp:gwacl |
Diff against target: |
34 lines (+9/-2) 2 files modified
Makefile (+3/-2) logging/logging_test.go (+6/-0) |
To merge this branch: | bzr merge lp:~allenap/gwacl/tests-not-testing |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+182865@code.launchpad.net |
Commit message
Get all tests running.
The logging tests were not running, but there was no obvious
indication that there was a problem; the module was developed in the
top-level gwacl package, moved to a sub-package when it was complete,
but it was missing the hook function from testing into gocheck.
In any case, `make check` would not have run tests in any sub-package.
When -gocheck.v is passed into `go test` the package specification
appears to be ignored, and only tests in the current package are
exercised.
Description of the change
Get all tests running.
The logging tests were not running, but there was no obvious
indication that there was a problem; the module was developed in the
top-level gwacl package, moved to a sub-package when it was complete,
but it was missing the hook function from testing into gocheck.
In any case, `make check` would not have run tests in any sub-package.
When -gocheck.v is passed into `go test` the package specification
appears to be ignored, and only tests in the current package are
exercised.
Please take a look.