Code review comment for lp:~allenap/gwacl/testing-not-verbose

John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-08-29 21:08, Gavin Panella wrote:
> Gavin Panella has proposed merging
> lp:~allenap/gwacl/testing-not-verbose into lp:gwacl.
>
> Commit message: Make tests verbose again.
>
> Requested reviews: GWACL Hackers (gwacl-hackers)
>
> For more details, see:
> https://code.launchpad.net/~allenap/gwacl/testing-not-verbose/+merge/182958
>
> Roger sussed the reason `go test -gocheck.v ./...` wsa not
> working; -gocheck.v was absorbing the ./... and not complaining
> about it, and `go test` was then happily testing the package in the
> current directory.
>

So the actual reason *I* would like "go test -v ./... -gocheck.v" is
because I'd like to see the progress as the tests complete (which you
get with go test -gocheck.v in a single dir).

Unfortunately, the way "go test ./..." works is that it saves up all
the output from the command until it finishes. And if it succeeds it
prints nothing (unless you pass -v) and if it fails it print something
(not sure what impact -gocheck.v has there).

Anyway, for what you're doing this is certainly correct. Just
mentioning it doesn't quite give what *I* would have hoped setting
verbose across the test suite would do.

 review: approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlIfmmMACgkQJdeBCYSNAAMyrgCfeNjNossgln5LbOvnR+iE8bwX
cCMAoMsUbs205Wb8IN+s8nqT1njihvpf
=5Yjt
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal