Merge lp:~allenap/gwacl/testing-not-verbose into lp:gwacl
Proposed by
Gavin Panella
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | 224 |
Merged at revision: | 223 |
Proposed branch: | lp:~allenap/gwacl/testing-not-verbose |
Merge into: | lp:gwacl |
Diff against target: |
15 lines (+4/-3) 1 file modified
Makefile (+4/-3) |
To merge this branch: | bzr merge lp:~allenap/gwacl/testing-not-verbose |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+182958@code.launchpad.net |
Commit message
Make tests verbose again.
Description of the change
Roger sussed the reason `go test -gocheck.v ./...` wsa not working; -gocheck.v was absorbing the ./... and not complaining about it, and `go test` was then happily testing the package in the current directory.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2013-08-29 21:08, Gavin Panella wrote: /code.launchpad .net/~allenap/ gwacl/testing- not-verbose/ +merge/ 182958
> Gavin Panella has proposed merging
> lp:~allenap/gwacl/testing-not-verbose into lp:gwacl.
>
> Commit message: Make tests verbose again.
>
> Requested reviews: GWACL Hackers (gwacl-hackers)
>
> For more details, see:
> https:/
>
> Roger sussed the reason `go test -gocheck.v ./...` wsa not
> working; -gocheck.v was absorbing the ./... and not complaining
> about it, and `go test` was then happily testing the package in the
> current directory.
>
So the actual reason *I* would like "go test -v ./... -gocheck.v" is
because I'd like to see the progress as the tests complete (which you
get with go test -gocheck.v in a single dir).
Unfortunately, the way "go test ./..." works is that it saves up all
the output from the command until it finishes. And if it succeeds it
prints nothing (unless you pass -v) and if it fails it print something
(not sure what impact -gocheck.v has there).
Anyway, for what you're doing this is certainly correct. Just
mentioning it doesn't quite give what *I* would have hoped setting
verbose across the test suite would do.
review: approve
-----BEGIN PGP SIGNATURE----- www.enigmail. net/
fmmMACgkQJdeBCY SNAAMyrgCfeNjNo ssgln5LbOvnR+ iE8bwX 8IN+s8nqT1njihv pf
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://
iEYEARECAAYFAlI
cCMAoMsUbs205Wb
=5Yjt
-----END PGP SIGNATURE-----