Merge lp:~allenap/gwacl/testing-not-verbose into lp:gwacl

Proposed by Gavin Panella on 2013-08-29
Status: Merged
Approved by: Gavin Panella on 2013-08-29
Approved revision: 224
Merged at revision: 223
Proposed branch: lp:~allenap/gwacl/testing-not-verbose
Merge into: lp:gwacl
Diff against target: 15 lines (+4/-3)
1 file modified
Makefile (+4/-3)
To merge this branch: bzr merge lp:~allenap/gwacl/testing-not-verbose
Reviewer Review Type Date Requested Status
John A Meinel 2013-08-29 Approve on 2013-08-29
Review via email: mp+182958@code.launchpad.net

Commit message

Make tests verbose again.

Description of the change

Roger sussed the reason `go test -gocheck.v ./...` wsa not working; -gocheck.v was absorbing the ./... and not complaining about it, and `go test` was then happily testing the package in the current directory.

To post a comment you must log in.
224. By Gavin Panella on 2013-08-29

Oops, missed a bit.

John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-08-29 21:08, Gavin Panella wrote:
> Gavin Panella has proposed merging
> lp:~allenap/gwacl/testing-not-verbose into lp:gwacl.
>
> Commit message: Make tests verbose again.
>
> Requested reviews: GWACL Hackers (gwacl-hackers)
>
> For more details, see:
> https://code.launchpad.net/~allenap/gwacl/testing-not-verbose/+merge/182958
>
> Roger sussed the reason `go test -gocheck.v ./...` wsa not
> working; -gocheck.v was absorbing the ./... and not complaining
> about it, and `go test` was then happily testing the package in the
> current directory.
>

So the actual reason *I* would like "go test -v ./... -gocheck.v" is
because I'd like to see the progress as the tests complete (which you
get with go test -gocheck.v in a single dir).

Unfortunately, the way "go test ./..." works is that it saves up all
the output from the command until it finishes. And if it succeeds it
prints nothing (unless you pass -v) and if it fails it print something
(not sure what impact -gocheck.v has there).

Anyway, for what you're doing this is certainly correct. Just
mentioning it doesn't quite give what *I* would have hoped setting
verbose across the test suite would do.

 review: approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlIfmmMACgkQJdeBCYSNAAMyrgCfeNjNossgln5LbOvnR+iE8bwX
cCMAoMsUbs205Wb8IN+s8nqT1njihvpf
=5Yjt
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2013-08-29 10:51:23 +0000
3+++ Makefile 2013-08-29 17:07:38 +0000
4@@ -1,7 +1,8 @@
5-# Build, and run tests. Do *not* pass -gocheck.v because it prevents
6-# tests in subdirectories from being run (a really _special_ bug).
7+# Build, and run tests. Be careful of the ordering of flags here; get
8+# it wrong and things can disappear into the void without warning.
9+# Yes, both -v and -gocheck.v=true are needed.
10 check: examples
11- go test ./...
12+ go test -v ./... -gocheck.v=true
13
14 debug-test:
15 go test -c -gcflags "-N -l"

Subscribers

People subscribed via source and target branches

to all changes: