Code review comment for lp:~allenap/gwacl/remove-role-endpoints

Raphaël Badin (rvb) wrote :

> On 23 July 2013 16:53, Raphaël Badin <email address hidden> wrote:
> > I think (name), (protocol, local port) and (protocol, port) are
> > natural keys for an endpoint.
> So a comparison would go something like, in order:
> - If Name matches, they're the same,
> - If Protocol and LocalPort match, they're the same,
> - If Protocol and Port match, they're the same,
> - Otherwise they're not the same.

On second thought that's probably a good solution. At first I thought we could only give it a list of names. That would be indeed much simpler but your solution is more flexible and will allow a user to remove endpoints based on the {port, protocol} and that's probably the best option.

> What about LoadBalancedEndpointSetName?
> Specifies a name for a set of load-balanced endpoints. Specifying
> this element for a given endpoint adds it to the set.
> That sounds like if it's set to a non-empty string then the natural
> key would be (set-name, protocol, port, local-port).
> This opens up more questions:
> - For a load-balanced endpoint set, does the public port have to be
> the same for all endpoints therein?

AFAIUI this is meant to be used to load-balance things between machine and so I don't think it adds any meaning when it comes to deciding what the natural keys are… but this is all surmise of course because the documentation is — once again — not very clear.

« Back to merge proposal