Code review comment for lp:~allenap/gwacl/remove-role-endpoints

Raphaël Badin (rvb) wrote :

> On 23 July 2013 16:53, Raphaël Badin <email address hidden> wrote:
> > I think (name), (protocol, local port) and (protocol, port) are
> > natural keys for an endpoint.
> So a comparison would go something like, in order:
> - If Name matches, they're the same,

Why not stop here? The name is a mandatory (well, I think) identifier.

> I'm still working on this branch... I think I'm going to land as soon
> as I can with a whopping FIXME in CompareInputEndpoints, and then do
> some experimentation to figure all the above out, at least that of it
> which is relevant to us.

Yeah, we need this ASAP to do the work on the provider so it seems like a good idea to land this sooner rather than later.

« Back to merge proposal