Code review comment for lp:~allenap/gwacl/remove-role-endpoints

Julian Edwards (julian-edwards) wrote :

On Friday 19 Jul 2013 13:52:26 Raphaël Badin wrote:
> This is clearly okay for the provider but I wonder if it would not be more
> straightforward, instead of passing whole endpoints objects, to pass just a
> list of the ports (the external ports) corresponding to the endpoints to be
> removed… because the code we have here imposes to create InputEndpoints
> structures where only the "natural key" (i.e. the external port) could be
> sufficient to identify the endpoints to be deleted. What do you think?

We talked the other day of wrapping add/remove-role-endpoints with another
func that does just take simple port numbers.

I am still not sure what Azure considers to be the primary key for an
endpoint, the documentation is not clear enough.

« Back to merge proposal