Merge lp:~allanlesage/indicator-power/restore-coverage-flags into lp:indicator-power/13.10

Proposed by Allan LeSage
Status: Merged
Approved by: Ted Gould
Approved revision: 184
Merged at revision: 184
Proposed branch: lp:~allanlesage/indicator-power/restore-coverage-flags
Merge into: lp:indicator-power/13.10
Diff against target: 48 lines (+15/-5)
1 file modified
src/Makefile.am (+15/-5)
To merge this branch: bzr merge lp:~allanlesage/indicator-power/restore-coverage-flags
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+179049@code.launchpad.net

Description of the change

This restores coverage reporting; we could alternately add the COVERAGE_CFLAGS to SHARED_CFLAGS instead.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Makes sense to me. We probably want to leave SHARED_CFLAGS for things
like generated code anyway.

  review approve
  status approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Makefile.am'
2--- src/Makefile.am 2013-07-04 20:14:54 +0000
3+++ src/Makefile.am 2013-08-07 21:10:42 +0000
4@@ -55,7 +55,12 @@
5 device-provider-upower.c \
6 device-provider-upower.h
7
8-libindicatorpower_upower_a_CFLAGS = $(SHARED_CFLAGS) -Wno-unused-parameter
9+libindicatorpower_upower_a_CFLAGS = \
10+ $(SHARED_CFLAGS) \
11+ -Wno-unused-parameter \
12+ $(COVERAGE_CFLAGS)
13+
14+libindciatorpower_upower_a_LDFLAGS = $(COVERAGE_LDFLAGS)
15
16 libindicatorpower_service_a_SOURCES = \
17 device-provider.c \
18@@ -65,7 +70,12 @@
19 service.c \
20 service.h
21
22-libindicatorpower_service_a_CFLAGS = $(SHARED_CFLAGS) -Wno-missing-field-initializers
23+libindicatorpower_service_a_CFLAGS = \
24+ $(SHARED_CFLAGS) \
25+ -Wno-missing-field-initializers \
26+ $(COVERAGE_CFLAGS)
27+
28+libindicatorpower_service_a_LDFLAGS = $(COVERAGE_LDFLAGS)
29
30 ###
31 ###
32@@ -75,7 +85,9 @@
33
34 indicator_power_service_SOURCES = main.c
35
36-indicator_power_service_CFLAGS = $(SHARED_CFLAGS)
37+indicator_power_service_CFLAGS = \
38+ $(SHARED_CFLAGS) \
39+ $(COVERAGE_CFLAGS)
40
41 indicator_power_service_LDADD = \
42 libindicatorpower-upower.a \
43@@ -84,5 +96,3 @@
44
45 indicator_power_service_LDFLAGS = \
46 $(COVERAGE_LDFLAGS)
47-
48-

Subscribers

People subscribed via source and target branches