Merge lp:~allanlesage/coverage-builder/test-fifty-percent-coverage into lp:coverage-builder

[Allan LeSage]

Quickie test for 50% coverage.

Martin you earlier suggested marking up the code with tags to extract--is just substituting the file adequate?

[Martin Pitt (pitti)]

Sure, replacing the entire file works too. I just meant that replacing a macro comment might be easier than always rewriting entire files for some tests.

The assertion needs to be fixed, otherwise LGTM. (Please just merge after fixing)

review: Needs Fixing

[lp:~allanlesage/coverage-builder/test-fifty-percent-coverage]

281. By Allan LeSage on 2014-09-16

Correct float assertion in incomplete coverage test.

=== modified file 'test/test_test.py'
--- test/test_test.py	2014-09-16 16:30:42 +0000
+++ test/test_test.py	2014-09-16 16:30:42 +0000
@@ -4,6 +4,7 @@
 # Author: Allan LeSage <[e-mail]>
 # License: GPL 3 or later
 
+import os
 import xml.etree.ElementTree as etree
 
 from test import CoverageBuilderTestCase, snip_coverage_xml
@@ -28,3 +29,26 @@
         root = etree.fromstring(coverage_xml)
         node = root.find(".//*[@filename='fibonacci.cpp']")
         self.assertEqual(1.0, float(node.attrib['line-rate']))
+
+    def test_fifty_percent_coverage(self):
+        """Accurate line coverage for a less thorough test suite."""
+        test_fibonacci_cpp_contents = """
+#include "gtest/gtest.h"
+#include "fibonacci.h"
+
+TEST(FibonacciTest, FirstTermIsCorrect) {
+  EXPECT_EQ(0, fib(0));
+}
+"""
+        with open(os.path.join(self.pkgdir,
+                               'tests',
+                               'test_fibonacci.cpp'),
+                  'w') as test_fibonacci_cpp:
+            test_fibonacci_cpp.write(test_fibonacci_cpp_contents)
+        self._call_dh_auto_configure()
+        self._call_dh_auto_build()
+        out, err = self._call_dh_auto_test()
+        coverage_xml = snip_coverage_xml(out.decode())
+        root = etree.fromstring(coverage_xml)
+        node = root.find(".//*[@filename='fibonacci.cpp']")
+        self.assertAlmostEqual(0.5, float(node.attrib['line-rate']))