Merge lp:~allanlesage/autopilot/fix-path_info-param-lp1119541 into lp:autopilot

[Allan LeSage]

Optionally passes new path_info param through super init.

A new 'path_info' param arrived in r127 which may have broken support for the flavors; this branch appears to fix, tested with the familiar GTK+ gedit test and passed one Unity launcher sanity test. Offering review to fginther as thomi and veebers are on holiday, elopio needing.

[Leo Arias (elopio)]

Tested here. Now I can start the vis and inspect Unity. Thanks Allan!

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:130
http://jenkins.qa.ubuntu.com/job/autopilot-ci/138/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-ci/./distribution=quantal,flavor=amd64/138/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-ci/./distribution=quantal,flavor=i386/138/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/autopilot-ci/138//rebuild/?

review: Approve (continuous-integration)

[Leo Arias (elopio)]

The vis hangs after a little while. I'll see if I can find debug info about that.
And launch is still not working:
elopio@tangamandapio-desktop:~/workspace/canonical/autopilot/reviews/allanlesage/fix-path_info-param-lp1119541$ ./bin/autopilot launch gedit
Error: Unable to find Autopilot interface.

after that, only unity is in the combo.

[Francis Ginther (fginther)]

Looks right. Approve.

review: Approve

[Francis Ginther (fginther)]

Ran a full unity autopilot test suite on my raring + staging system with results consistent with prior runs. No noticeable regressions.

[Allan LeSage (allanlesage)]

I was able to resolve elopio's issues, setting this to approve.

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
No commit message was specified in the merge proposal; hit 'Add commit message' on the merge proposal web page and approve the merge proposal again yourself to rerun.

review: Needs Fixing (continuous-integration)

=== modified file 'autopilot/introspection/__init__.py'
--- autopilot/introspection/__init__.py	2012-12-03 01:57:49 +0000
+++ autopilot/introspection/__init__.py	2013-02-08 16:40:31 +0000
@@ -208,8 +208,8 @@
 class ApplicationProxyObect(DBusIntrospectionObject):
     """A class that better supports query data from an application."""
 
-    def __init__(self, state):
-        super(ApplicationProxyObect, self).__init__(state)
+    def __init__(self, state, path_info=None):
+        super(ApplicationProxyObect, self).__init__(state, path_info)
         self._process = None
 
     def select_single(self, type_name='*', **kwargs):