Merge ~alichtman/ubuntu/+source/ubuntu-meta:heif-support-by-default into ubuntu/+source/ubuntu-meta:ubuntu/devel

Proposed by Aaron Lichtman
Status: Rejected
Rejected by: Robie Basak
Proposed branch: ~alichtman/ubuntu/+source/ubuntu-meta:heif-support-by-default
Merge into: ubuntu/+source/ubuntu-meta:ubuntu/devel
Diff against target: 94 lines (+20/-0)
7 files modified
debian/changelog (+8/-0)
desktop-recommends-amd64 (+2/-0)
desktop-recommends-arm64 (+2/-0)
desktop-recommends-armhf (+2/-0)
desktop-recommends-ppc64el (+2/-0)
desktop-recommends-riscv64 (+2/-0)
desktop-recommends-s390x (+2/-0)
Reviewer Review Type Date Requested Status
Steve Langasek (community) Disapprove
git-ubuntu import Pending
Review via email: mp+442067@code.launchpad.net

Commit message

Add HEIF / HEIC support by default on desktop

Adding heif-gdk-pixbuf and heif-thumbnailer to the desktop-recommends-* files will allow HEIF / HEIC files to be shown in thumbnails in Nautilus, and previewed in eog, by default.

Fixes Bug #1886271
https://bugs.launchpad.net/ubuntu/+source/eog/+bug/1886271

Description of the change

I'm not really sure how to test this definitively, or if this merge request is going to the right branch. Please lmk if there's a better place for this to go.

I was able to solve the problem described in the bug report on my Ubuntu machine by installing these packages, so this change makes sense to me.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

This is not the right branch to merge to; the contents of the ubuntu-meta package are autogenerated from https://code.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu/ using the ./update script.

Also, libheif is in universe, not in main. All packages must go through the main inclusion process https://github.com/canonical/ubuntu-mir before they are accepted into main. An MIR was started for libheif some time ago (bug #1827442) but the package as of today does not meet the requirements to be promoted to main.

I am therefore rejecting this MP.

If and when libheif is accepted into main, it is also preferred that these components be pulled in as depends/recommends of the application that use them, rather than being directly seeded in ubuntu-meta.

review: Disapprove

Unmerged commits

c67add6... by Aaron Lichtman

Add HEIF / HEIC support by default on desktop

This will allow HEIF / HEIC files to be shown in thumbnails in Nautilus,
and previewed in eog.

Fixes Bug #1886271
https://bugs.launchpad.net/ubuntu/+source/eog/+bug/1886271

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index fe26354..333b641 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+ubuntu-meta (1.502) UNRELEASED; urgency=medium
7+
8+ * Refreshed dependencies
9+ * Added heif-gdk-pixbuf to desktop-recommends
10+ * Added heif-thumbnailer to desktop-recommends
11+
12+ -- Aaron Lichtman <aaronlichtman@gmail.com> Thu, 27 Apr 2023 23:47:14 -0700
13+
14 ubuntu-meta (1.501) lunar; urgency=medium
15
16 * Refreshed dependencies
17diff --git a/desktop-recommends-amd64 b/desktop-recommends-amd64
18index 7555ca6..ed9c5ba 100644
19--- a/desktop-recommends-amd64
20+++ b/desktop-recommends-amd64
21@@ -60,6 +60,8 @@ gnome-text-editor
22 gpg-agent
23 gsettings-ubuntu-schemas
24 gvfs-fuse
25+heif-gdk-pixbuf
26+heif-thumbnailer
27 hplip
28 ibus
29 ibus-gtk
30diff --git a/desktop-recommends-arm64 b/desktop-recommends-arm64
31index bf94035..4879725 100644
32--- a/desktop-recommends-arm64
33+++ b/desktop-recommends-arm64
34@@ -60,6 +60,8 @@ gnome-text-editor
35 gpg-agent
36 gsettings-ubuntu-schemas
37 gvfs-fuse
38+heif-gdk-pixbuf
39+heif-thumbnailer
40 hplip
41 ibus
42 ibus-gtk
43diff --git a/desktop-recommends-armhf b/desktop-recommends-armhf
44index 1261cc7..fd8eab1 100644
45--- a/desktop-recommends-armhf
46+++ b/desktop-recommends-armhf
47@@ -59,6 +59,8 @@ gnome-text-editor
48 gpg-agent
49 gsettings-ubuntu-schemas
50 gvfs-fuse
51+heif-gdk-pixbuf
52+heif-thumbnailer
53 hplip
54 ibus
55 ibus-gtk
56diff --git a/desktop-recommends-ppc64el b/desktop-recommends-ppc64el
57index 9e67942..bb5a4e1 100644
58--- a/desktop-recommends-ppc64el
59+++ b/desktop-recommends-ppc64el
60@@ -58,6 +58,8 @@ gnome-text-editor
61 gpg-agent
62 gsettings-ubuntu-schemas
63 gvfs-fuse
64+heif-gdk-pixbuf
65+heif-thumbnailer
66 hplip
67 ibus
68 ibus-gtk
69diff --git a/desktop-recommends-riscv64 b/desktop-recommends-riscv64
70index a4112c3..1489ab3 100644
71--- a/desktop-recommends-riscv64
72+++ b/desktop-recommends-riscv64
73@@ -58,6 +58,8 @@ gnome-text-editor
74 gpg-agent
75 gsettings-ubuntu-schemas
76 gvfs-fuse
77+heif-gdk-pixbuf
78+heif-thumbnailer
79 hplip
80 ibus
81 ibus-gtk
82diff --git a/desktop-recommends-s390x b/desktop-recommends-s390x
83index 9e67942..bb5a4e1 100644
84--- a/desktop-recommends-s390x
85+++ b/desktop-recommends-s390x
86@@ -58,6 +58,8 @@ gnome-text-editor
87 gpg-agent
88 gsettings-ubuntu-schemas
89 gvfs-fuse
90+heif-gdk-pixbuf
91+heif-thumbnailer
92 hplip
93 ibus
94 ibus-gtk

Subscribers

People subscribed via source and target branches