Merge lp:~alhashash/openobject-addons/Fix_1087681_incorrect_move_line_defaults into lp:openobject-addons

[Mohammad Alhashash]

in account.move_line._default_get(), do not use 'partner_id' or 'ref' from other lines as a default unless they are the same for all lines.

Unmerged revisions

8236. By alhashash <alhashash@centos6-devel> on 2012-12-07

in account.move_line._default_get(), do not use 'partner_id' or 'ref' as a default from other line unless they are the same for all lines. Bug #1087681

=== modified file 'account/account_move_line.py'
--- account/account_move_line.py	2012-12-06 11:05:28 +0000
+++ account/account_move_line.py	2012-12-07 14:49:23 +0000
@@ -264,12 +264,19 @@
                 if move_id:
                     #if there exist some unbalanced accounting entries that match the journal and the period,
                     #we propose to continue the same move by copying the ref, the name, the partner...
+                    #ref and partners are copied only if all lines has the same ref or partner
                     move = move_obj.browse(cr, uid, move_id, context=context)
                     data.setdefault('name', move.line_id[-1].name)
+                    partner_set = set()
+                    ref_set = set()
                     for l in move.line_id:
-                        data['partner_id'] = data.get('partner_id') or l.partner_id.id
-                        data['ref'] = data.get('ref') or l.ref
+                        partner_set.add(l.partner_id.id)
+                        ref_set.add(l.ref)
                         total += (l.debit or 0.0) - (l.credit or 0.0)
+                    if len(partner_set) == 1:  # same partner for all
+                        data['partner_id'] = data.get('partner_id') or partner_set.pop()
+                    if len(ref_set) == 1:  # same ref for all
+                        data['ref'] = data.get('ref') or ref_set.pop()
 
             #compute the total of current move
             data['debit'] = total < 0 and -total or 0.0