Merge ~alfonsosanchezbeato/ubuntu/+source/gst-plugins-bad1.0:master into ~ubuntu-desktop/ubuntu/+source/gst-plugins-bad1.0:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Merged at revision: 550e97b3267df1c6191cb098d5a907971bd1ce18
Proposed branch: ~alfonsosanchezbeato/ubuntu/+source/gst-plugins-bad1.0:master
Merge into: ~ubuntu-desktop/ubuntu/+source/gst-plugins-bad1.0:master
Diff against target: 159 lines (+28/-16)
2 files modified
debian/changelog (+6/-0)
debian/patches/adding-mirsink-and-android-media-over-hybris-support.patch (+22/-16)
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+273509@code.launchpad.net

Description of the change

Release buffer pool when mirsinkg stops to avoid fd and memory leakage.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index e93177d..52dfc8d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+gst-plugins-bad1.0 (1.5.91-1ubuntu2) UNRELEASED; urgency=medium
7+
8+ * Release buffer pool when mirsink stops
9+
10+ -- Alfonso Sanchez-Beato (email Canonical) <alfonso.sanchez-beato@canonical.com> Tue, 06 Oct 2015 11:15:21 +0200
11+
12 gst-plugins-bad1.0 (1.5.91-1ubuntu1) wily; urgency=medium
13
14 * Merge with Debian experimental; remaining changes:
15diff --git a/debian/patches/adding-mirsink-and-android-media-over-hybris-support.patch b/debian/patches/adding-mirsink-and-android-media-over-hybris-support.patch
16index d574b0d..8b97d09 100644
17--- a/debian/patches/adding-mirsink-and-android-media-over-hybris-support.patch
18+++ b/debian/patches/adding-mirsink-and-android-media-over-hybris-support.patch
19@@ -12,7 +12,7 @@ Forwarded: no
20 configure.ac | 15 +
21 ext/Makefile.am | 8 +
22 ext/mir/Makefile.am | 17 +
23- ext/mir/gstmirsink.c | 848 ++++++++++
24+ ext/mir/gstmirsink.c | 854 ++++++++++
25 ext/mir/gstmirsink.h | 134 ++
26 ext/mir/mirpool.c | 434 +++++
27 ext/mir/mirpool.h | 91 ++
28@@ -34,7 +34,7 @@ Forwarded: no
29 tests/check/Makefile.am | 7 +
30 tests/check/pipelines/gstamcvideodec.c | 538 +++++++
31 tests/check/pipelines/gstamcvideodec_egl.c | 56 +
32- 25 files changed, 8751 insertions(+), 6 deletions(-)
33+ 25 files changed, 8757 insertions(+), 6 deletions(-)
34 create mode 100644 ext/mir/Makefile.am
35 create mode 100644 ext/mir/gstmirsink.c
36 create mode 100644 ext/mir/gstmirsink.h
37@@ -52,10 +52,10 @@ Forwarded: no
38 create mode 100644 tests/check/pipelines/gstamcvideodec_egl.c
39
40 diff --git a/configure.ac b/configure.ac
41-index 59566d4..96c0152 100644
42+index 1c06bed..54c2852 100644
43 --- a/configure.ac
44 +++ b/configure.ac
45-@@ -1591,6 +1591,18 @@ AG_GST_CHECK_FEATURE(ANDROID_MEDIA, [Android Media], androidmedia, [
46+@@ -1606,6 +1606,18 @@ AG_GST_CHECK_FEATURE(ANDROID_MEDIA, [Android Media], androidmedia, [
47 esac
48 ])
49
50@@ -74,7 +74,7 @@ index 59566d4..96c0152 100644
51 dnl *** AppleMedia (OS X and iOS) ***
52 translit(dnm, m, l) AM_CONDITIONAL(USE_APPLE_MEDIA, true)
53 HAVE_APPLE_MEDIA="no"
54-@@ -3000,6 +3012,7 @@ AM_CONDITIONAL(DECKLINK_OSX, false)
55+@@ -3086,6 +3098,7 @@ AM_CONDITIONAL(DECKLINK_OSX, false)
56 AM_CONDITIONAL(USE_DIRECTFB, false)
57 AM_CONDITIONAL(USE_WAYLAND, false)
58 AM_CONDITIONAL(USE_DAALA, false)
59@@ -82,7 +82,7 @@ index 59566d4..96c0152 100644
60 AM_CONDITIONAL(USE_DTS, false)
61 AM_CONDITIONAL(USE_EXIF, false)
62 AM_CONDITIONAL(USE_RESINDVD, false)
63-@@ -3232,6 +3245,7 @@ gst-libs/gst/gl/egl/Makefile
64+@@ -3319,6 +3332,7 @@ gst-libs/gst/gl/egl/Makefile
65 gst-libs/gst/gl/wayland/Makefile
66 gst-libs/gst/gl/win32/Makefile
67 gst-libs/gst/gl/x11/Makefile
68@@ -90,7 +90,7 @@ index 59566d4..96c0152 100644
69 gst-libs/gst/insertbin/Makefile
70 gst-libs/gst/interfaces/Makefile
71 gst-libs/gst/codecparsers/Makefile
72-@@ -3311,6 +3325,7 @@ ext/dc1394/Makefile
73+@@ -3398,6 +3412,7 @@ ext/dc1394/Makefile
74 ext/directfb/Makefile
75 ext/wayland/Makefile
76 ext/daala/Makefile
77@@ -99,7 +99,7 @@ index 59566d4..96c0152 100644
78 ext/gl/Makefile
79 ext/gtk/Makefile
80 diff --git a/ext/Makefile.am b/ext/Makefile.am
81-index 66dccd6..e403264 100644
82+index 33ddba7..ee47a92 100644
83 --- a/ext/Makefile.am
84 +++ b/ext/Makefile.am
85 @@ -76,6 +76,12 @@ else
86@@ -115,7 +115,7 @@ index 66dccd6..e403264 100644
87 if USE_DTS
88 DTS_DIR=dts
89 else
90-@@ -457,6 +463,7 @@ SUBDIRS=\
91+@@ -464,6 +470,7 @@ SUBDIRS=\
92 $(LIBFAME_DIR) \
93 $(LIBMMS_DIR) \
94 $(LIBVISUAL_DIR) \
95@@ -123,7 +123,7 @@ index 66dccd6..e403264 100644
96 $(MODPLUG_DIR) \
97 $(MPEG2ENC_DIR) \
98 $(MPG123_DIR) \
99-@@ -507,6 +514,7 @@ DIST_SUBDIRS = \
100+@@ -514,6 +521,7 @@ DIST_SUBDIRS = \
101 dc1394 \
102 directfb \
103 wayland \
104@@ -156,10 +156,10 @@ index 0000000..d588fc7
105 +noinst_HEADERS =
106 diff --git a/ext/mir/gstmirsink.c b/ext/mir/gstmirsink.c
107 new file mode 100644
108-index 0000000..987117e
109+index 0000000..ca88ae3
110 --- /dev/null
111 +++ b/ext/mir/gstmirsink.c
112-@@ -0,0 +1,848 @@
113+@@ -0,0 +1,854 @@
114 +/*
115 + * GStreamer Mir video sink
116 + * Copyright (C) 2013 Canonical Ltd
117@@ -791,6 +791,12 @@ index 0000000..987117e
118 +
119 + GST_DEBUG_OBJECT (sink, "stop");
120 +
121++ /* The pool is not re-used so must be destroyed here */
122++ if (sink->pool) {
123++ gst_object_unref (sink->pool);
124++ sink->pool = NULL;
125++ }
126++
127 + /* MediaCodec (hybris layer) will destroy the underlying
128 + * SurfaceTextureClientHybris instance, * so set it to NULL here so that
129 + * we don't point to an invalid instance.
130@@ -2377,7 +2383,7 @@ index 5fcfb8f..2628a8a 100644
131 libgstandroidmedia_la_LDFLAGS = $(GST_PLUGIN_LDFLAGS)
132 libgstandroidmedia_la_LIBTOOLFLAGS = $(GST_PLUGIN_LIBTOOLFLAGS)
133 diff --git a/sys/androidmedia/gstamc-constants.h b/sys/androidmedia/gstamc-constants.h
134-index ae52464..f5bb86f 100644
135+index cc43f61..8984f5a 100644
136 --- a/sys/androidmedia/gstamc-constants.h
137 +++ b/sys/androidmedia/gstamc-constants.h
138 @@ -93,6 +93,8 @@ enum
139@@ -2404,7 +2410,7 @@ index ae52464..f5bb86f 100644
140
141 enum
142 diff --git a/sys/androidmedia/gstamc.h b/sys/androidmedia/gstamc.h
143-index 88d49fb..567752e 100644
144+index a3fb9bc..eda5278 100644
145 --- a/sys/androidmedia/gstamc.h
146 +++ b/sys/androidmedia/gstamc.h
147 @@ -24,12 +24,67 @@
148@@ -8551,10 +8557,10 @@ index 0000000..cff94c4
149 + return TRUE;
150 +}
151 diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am
152-index 295791b..1d42491 100644
153+index 1e5c23a..90a2271 100644
154 --- a/tests/check/Makefile.am
155 +++ b/tests/check/Makefile.am
156-@@ -211,6 +211,12 @@ else
157+@@ -210,6 +210,12 @@ else
158 check_gl=
159 endif
160

Subscribers

People subscribed via source and target branches