Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/wifi-ap:fix-wizard-mask into ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-ap:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: c22330dca04adb34346604a2f280cdebcd8d4ec9
Merged at revision: 6ca9c2e900d6109e43e09d7ab70125dc0f5ae8b6
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/wifi-ap:fix-wizard-mask
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/wifi-ap:master
Diff against target: 15 lines (+3/-1)
1 file modified
cmd/client/cmd_wizard.go (+3/-1)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Tony Espy Approve
Review via email: mp+359636@code.launchpad.net

Commit message

Set properly the interface netmask

Previously we were getting hex numbers instead of a properly formatted
netmask (i.e. ff000000 instead of 255.0.0.0) when running the wizard.

Description of the change

Set properly the interface netmask

Previously we were getting hex numbers instead of a properly formatted
netmask (i.e. ff000000 instead of 255.0.0.0) when running the wizard.

To post a comment you must log in.
Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: c22330dca04adb34346604a2f280cdebcd8d4ec9

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1132/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/cmd/client/cmd_wizard.go b/cmd/client/cmd_wizard.go
2index 41dd538..b2080bc 100644
3--- a/cmd/client/cmd_wizard.go
4+++ b/cmd/client/cmd_wizard.go
5@@ -238,7 +238,9 @@ var allSteps = [...]wizardStep{
6 }
7
8 configuration["wifi.address"] = inputIp
9- configuration["wifi.netmask"] = ipv4.DefaultMask().String()
10+ mask := ipv4.DefaultMask()
11+ configuration["wifi.netmask"] =
12+ fmt.Sprintf("%d.%d.%d.%d", mask[0], mask[1], mask[2], mask[3])
13
14 return nil
15 },

Subscribers

People subscribed via source and target branches