Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/tests-extras:sync-kpartx into ~snappy-hwe-team/snappy-hwe-snaps/+git/tests-extras:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 64bea9f86738250e4140144cfa3282913eecebda
Merged at revision: 838293698274ad7d0b3637abb0edb06c87f9c9da
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/tests-extras:sync-kpartx
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/tests-extras:master
Diff against target: 15 lines (+2/-2)
1 file modified
create-image-scripts/create-image.sh (+2/-2)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+333146@code.launchpad.net

Description of the change

Sync before exiting kpartx, so the sleep is not necessary

To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) :
review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/create-image-scripts/create-image.sh b/create-image-scripts/create-image.sh
2index 3129d37..dd135c7 100755
3--- a/create-image-scripts/create-image.sh
4+++ b/create-image-scripts/create-image.sh
5@@ -107,8 +107,8 @@ ubuntu-image \
6 $model.model
7
8 mv $model.img $image_name
9-kpartx -a $image_name
10-sleep 0.5
11+# -s: don't return until the partitions are created
12+kpartx -asv $image_name
13
14 loop_path=$(findfs LABEL=writable)
15 tmp_mount=$(mktemp -d)

Subscribers

People subscribed via source and target branches