Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/pulseaudio:do-not-fork into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master

[Alfonso Sanchez-Beato]

Do not unnecessarily fork when starting daemon

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:049cd110c5e6caf3b74b3a2e2d09c3b11cd37aaf
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1638/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2088
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1546/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2459
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1641/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1638/rebuild

review: Approve (continuous-integration)

[Konrad Zapałowicz (kzapalowicz)]

ack

review: Approve (code)

[Simon Fels (morphis)]

LGTM

review: Approve

diff --git a/bin/pulseaudio b/bin/pulseaudio
index 40c9a85..fa1c474 100755
--- a/bin/pulseaudio
+++ b/bin/pulseaudio
@@ -19,7 +19,7 @@ if [ -e $SNAP_DATA/config/debug ] ; then
     export LIBASOUND_DEBUG=1
 fi
 
-$SNAP/usr/bin/pulseaudio \
+exec $SNAP/usr/bin/pulseaudio \
     --exit-idle-time=-1 \
     --disallow-exit=yes \
     --disallow-module-loading \
diff --git a/tests/main/installation/task.yaml b/tests/main/installation/task.yaml
index d320c61..20d742d 100644
--- a/tests/main/installation/task.yaml
+++ b/tests/main/installation/task.yaml
@@ -7,6 +7,9 @@ execute: |
     wait_for_pulseaudio
     systemctl status snap.pulseaudio.pulseaudio | grep -Pzq ': active'
 
+    # Make sure the daemon's parent is PID 1
+    pgrep -P 1 pulseaudio
+
     # pactl should be able to reach PulseAudio
     /snap/bin/pactl list | grep -Pzq 'Module'