Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:not-run-all-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:snap-20

[Alfonso Sanchez-Beato]

Enable again checks, after disabling some failing tests:
Some tests where failing due to limitations of the launchpad builders:
disable just those but run the rest of unit tests when building.

Enable again checks, after disabling some failing tests:
Some tests where failing due to limitations of the launchpad builders:
disable just those but run the rest of unit tests when building.

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:4e84fb16de535377c9b96d5a24b07f9f27947802
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/511/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/544
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/544
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/544
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/544
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1333
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1075
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1124/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/511/rebuild

review: Approve (continuous-integration)

diff --git a/snap-patch/networkmanager/0002-Disable-tests-failing-on-launchpad.patch b/snap-patch/networkmanager/0002-Disable-tests-failing-on-launchpad.patch
new file mode 100644
index 0000000..98c5d5d
--- /dev/null
+++ b/snap-patch/networkmanager/0002-Disable-tests-failing-on-launchpad.patch
@@ -0,0 +1,96 @@
+From b4557f86c968d78e6000661931ee3c265e38002a Mon Sep 17 00:00:00 2001
+From: snapcraft <[e-mail]>
+Date: Wed, 8 Jul 2020 14:34:37 +0200
+Subject: [PATCH] Disable tests failing on launchpad
+
+---
+ Makefile.am                    | 6 +-----
+ Makefile.in                    | 4 ----
+ src/devices/tests/meson.build  | 1 -
+ src/platform/tests/meson.build | 3 ---
+ 4 files changed, 1 insertion(+), 13 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index b37aa4e71..f737b07db 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -3730,15 +3730,12 @@ check_programs_norun += \
+ 
+ check_programs += \
+ 	src/platform/tests/test-address-fake \
+-	src/platform/tests/test-address-linux \
+ 	src/platform/tests/test-cleanup-fake \
+ 	src/platform/tests/test-cleanup-linux \
+ 	src/platform/tests/test-link-fake \
+-	src/platform/tests/test-link-linux \
+ 	src/platform/tests/test-nmp-object \
+ 	src/platform/tests/test-platform-general \
+ 	src/platform/tests/test-route-fake \
+-	src/platform/tests/test-route-linux \
+ 	$(NULL)
+ 
+ src_platform_tests_monitor_CPPFLAGS = $(src_cppflags_test)
+@@ -3818,8 +3815,7 @@ src_devices_tests_ldflags = \
+ 	$(SANITIZER_EXEC_LDFLAGS)
+ 
+ check_programs += \
+-	src/devices/tests/test-lldp \
+-	src/devices/tests/test-acd
++	src/devices/tests/test-lldp
+ 
+ src_devices_tests_test_lldp_CPPFLAGS = $(src_cppflags_test)
+ src_devices_tests_test_lldp_LDFLAGS = $(src_devices_tests_ldflags)
+diff --git a/Makefile.in b/Makefile.in
+index fba5b556a..f6489053d 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -4705,16 +4705,12 @@ check_programs = shared/nm-utils/tests/test-shared-general \
+ 	$(am__append_24) $(am__append_31) $(am__append_35) \
+ 	$(am__append_44) src/dnsmasq/tests/test-dnsmasq-utils \
+ 	src/platform/tests/test-address-fake \
+-	src/platform/tests/test-address-linux \
+ 	src/platform/tests/test-cleanup-fake \
+ 	src/platform/tests/test-cleanup-linux \
+ 	src/platform/tests/test-link-fake \
+-	src/platform/tests/test-link-linux \
+ 	src/platform/tests/test-nmp-object \
+ 	src/platform/tests/test-platform-general \
+ 	src/platform/tests/test-route-fake \
+-	src/platform/tests/test-route-linux $(NULL) \
+-	src/devices/tests/test-lldp src/devices/tests/test-acd \
+ 	src/ndisc/tests/test-ndisc-fake \
+ 	src/supplicant/tests/test-supplicant-config \
+ 	src/tests/config/test-config src/tests/test-core \
+diff --git a/src/devices/tests/meson.build b/src/devices/tests/meson.build
+index bb53d1ee4..457d368c2 100644
+--- a/src/devices/tests/meson.build
++++ b/src/devices/tests/meson.build
+@@ -1,5 +1,4 @@
+ test_units = [
+-  'test-acd',
+   'test-lldp',
+ ]
+ 
+diff --git a/src/platform/tests/meson.build b/src/platform/tests/meson.build
+index 6f7173b6d..342aa1c81 100644
+--- a/src/platform/tests/meson.build
++++ b/src/platform/tests/meson.build
+@@ -3,15 +3,12 @@ test_linux_c_flags = test_c_flags + ['-DSETUP=nm_linux_platform_setup']
+ 
+ test_units = [
+   ['test-address-fake', 'test-address.c', test_fake_c_flags, default_test_timeout],
+-  ['test-address-linux', 'test-address.c', test_linux_c_flags, default_test_timeout],
+   ['test-cleanup-fake', 'test-cleanup.c', test_fake_c_flags, default_test_timeout],
+   ['test-cleanup-linux', 'test-cleanup.c', test_linux_c_flags, default_test_timeout],
+   ['test-link-fake', 'test-link.c', test_fake_c_flags, default_test_timeout],
+-  ['test-link-linux', 'test-link.c', test_linux_c_flags, 900],
+   ['test-nmp-object', 'test-nmp-object.c', test_c_flags, default_test_timeout],
+   ['test-platform-general', 'test-platform-general.c', test_c_flags, default_test_timeout],
+   ['test-route-fake', 'test-route.c', test_fake_c_flags, default_test_timeout],
+-  ['test-route-linux', 'test-route.c', test_linux_c_flags, default_test_timeout],
+ ]
+ 
+ foreach test_unit: test_units
+-- 
+2.25.1
+
diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index 0942716..ed91c05 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -227,7 +227,7 @@ parts:
       snapcraftctl build
 
       # Run all tests NetworkManager ships by default
-      #make check
+      make check
     stage-packages:
       - iputils-arping
       - libasn1-8-heimdal