snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:fix-warning into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager
  3. fix-warning
  4. Merge into network-manager/xenial/1.2.2
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Konrad Zapałowicz
Approved revision: a155a16585dedaa9643e9c27840ccf707e56a27a
Merged at revision: 98773dc6f13090b49d5d363856d2b3f84e461fa4
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:fix-warning
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2
Diff against target: 13 lines (+1/-1)
1 file modified
src/systemd/src/libsystemd-network/sd-ipv4acd.c (+1/-1)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Alfonso Sanchez-Beato continuous-integration Approve
Konrad Zapałowicz (community) code Approve
Review via email: mp+354757@code.launchpad.net

Description of the change

Initialize properly variable in sd-ipv4acd.c

To avoid compiler warning.

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

ack

review: Approve (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:a155a16585dedaa9643e9c27840ccf707e56a27a
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/281/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/324
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/324
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/324
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/324
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1116
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/859
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/894/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/281/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/systemd/src/libsystemd-network/sd-ipv4acd.c b/src/systemd/src/libsystemd-network/sd-ipv4acd.c
2index 867987c..58ea27f 100644
3--- a/src/systemd/src/libsystemd-network/sd-ipv4acd.c
4+++ b/src/systemd/src/libsystemd-network/sd-ipv4acd.c
5@@ -359,7 +359,7 @@ static int ipv4acd_on_packet(
6 sd_ipv4acd *ll = userdata;
7 struct ether_arp packet;
8 ssize_t n;
9- int r;
10+ int r = 0;
11
12 assert(s);
13 assert(ll);

Subscribers

People subscribed via source and target branches