snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:enable-o2 into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager
  3. enable-o2
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: a642c007353057bec0d13ab4dbe9e170f6176ffd
Merged at revision: 2453b39736aa2074be3cd4e2ecad5e5041d18356
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:enable-o2
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master
Diff against target: 13 lines (+2/-0)
1 file modified
snapcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Tony Espy Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+354748@code.launchpad.net

Description of the change

Compile wiht optimizations turned on

Override snapcraft's CFLAGS to make sure -O2 is set and -g is not
(LP: #1791333).

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: a642c007353057bec0d13ab4dbe9e170f6176ffd

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1114/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:a642c007353057bec0d13ab4dbe9e170f6176ffd
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/279/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/322
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/322
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/322
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/322
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1114
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/857
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/892/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/279/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 2c8c9a5..4a6a9ef 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -142,6 +142,8 @@ parts:
6 # We want to support ModemManager
7 - --with-modem-manager-1=yes
8 - --enable-tests=yes
9+ # Set explicitly CFLAGS until lp: #1791946 is solved
10+ - CFLAGS=-O2
11
12 install: |
13 # Run all tests NetworkManager ships by default

Subscribers

People subscribed via source and target branches