Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:add-no-wowlan-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

[Alfonso Sanchez-Beato]

Add test that checks interfaces on NM stop

Test that verifies that wifi interfaces are unconfigured when NM is
stopped in WoWLAN is not supported

Add test that checks interfaces on NM stop

Test that verifies that wifi interfaces are unconfigured when NM is
stopped in WoWLAN is not supported.

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:e8c313204f44c1475e84f4c8614179198265228a
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1504/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1273
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1412/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1701
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/887/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1504/rebuild

review: Approve (continuous-integration)

[Konrad Zapałowicz (kzapalowicz)]

ack

review: Approve (lgtm)

[Simon Fels (morphis)]

LGTM

review: Approve

diff --git a/tests/main/wifi-no-wowlan-iface-removed/task.yaml b/tests/main/wifi-no-wowlan-iface-removed/task.yaml
new file mode 100644
index 0000000..1e8f759
--- /dev/null
+++ b/tests/main/wifi-no-wowlan-iface-removed/task.yaml
@@ -0,0 +1,43 @@
+summary: |
+    Verify that WiFi interface is removed after NM stops if WoWLAN is
+    not supported, even if enabled by NM.
+
+execute: |
+    # Enable WoWLAN globally for all new WiFi connections
+    snap set network-manager wifi.wake-on-wlan=any
+
+    # Replace core wpa-supplicant with one from snap
+    sudo systemctl stop wpa_supplicant.service
+    # TODO Install from stable when wowlan change lands
+    snap install --edge wpa-supplicant
+    snap connect network-manager:wpa wpa-supplicant:service
+    sudo systemctl restart snap.network-manager.networkmanager.service
+
+    # mac80211_hwsim does not support wowlan, check that
+    ! iw phy phy0 wowlan show
+
+    # Get us an AP via the wifi-ap we can use to create a connection to
+    snap install wifi-ap
+
+    # AP needs a bit to appear and be visible for NetworkManager
+    /snap/bin/network-manager.nmcli d wifi rescan
+    while ! /snap/bin/network-manager.nmcli d wifi | grep Ubuntu ; do
+        /snap/bin/network-manager.nmcli d wifi rescan
+        sleep 1
+    done
+
+    # Connect to the AP and ensure the connection was established
+    /snap/bin/network-manager.nmcli d wifi | grep Ubuntu
+    /snap/bin/network-manager.nmcli d wifi connect Ubuntu
+    /snap/bin/network-manager.nmcli d | grep 'wlan1.*connected'
+    ip address show wlan1 | grep -q inet
+
+    # Now that we're connected a new connection exists which we can look at
+    # to verify that the WoWLAN key is correctly set.
+    /snap/bin/network-manager.nmcli c show Ubuntu | grep '802-11-wireless.wake-on-wlan:.*default (1)'
+
+    # Stop NM, then check that the interface is not configured anymore
+    sudo systemctl stop snap.network-manager.networkmanager.service
+
+    ip address show wlan1 | grep -vq inet
+    ip address show wlan1 | grep -q "state DOWN"