snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:remove-more-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager
  3. remove-more-tests
  4. Merge into network-manager/xenial/1.2.2
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 0f688f7aa7e680a80316b9343e9b44c99742d347
Merged at revision: b679073a5d61df2ae417819f6f593c9080234933
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:remove-more-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2
Diff against target: 10 lines (+0/-1)
1 file modified
src/devices/tests/Makefile.am (+0/-1)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Matteo Croce (community) Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+319171@code.launchpad.net

Commit message

Remove lldp tests from Makefile.am

This tests do not work in the CI environment.

Description of the change

Remove lldp tests from Makefile.am

This tests do not work in the CI environment.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:7ce7ca9175907d8932d3e0b59a77e19873d8822e
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1200/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/248/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1107/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/923/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1200/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:7ce7ca9175907d8932d3e0b59a77e19873d8822e
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1209/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/257/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1117/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1209/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:0f688f7aa7e680a80316b9343e9b44c99742d347
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1210/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/258
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1118/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/926

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1210/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:0f688f7aa7e680a80316b9343e9b44c99742d347
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1211/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/259
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1119/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/927

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1211/rebuild

review: Approve (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/devices/tests/Makefile.am b/src/devices/tests/Makefile.am
2index cd1ef6e..8a56f98 100644
3--- a/src/devices/tests/Makefile.am
4+++ b/src/devices/tests/Makefile.am
5@@ -51,5 +51,4 @@ test_arping_LDADD = $(DEVICES_LDADD)
6
7 @VALGRIND_RULES@
8 TESTS = \
9- test-lldp \
10 test-arping

Subscribers

People subscribed via source and target branches